fixing some eslint issues

Author: amejiarosario

lib/data-structures/graphs/graph.js

@@ -37,13 +37,12 @@ class Graph {
    * @param {any} value node's value
    */
   addVertex(value) {
-    if(this.nodes.has(value)) {
+    if (this.nodes.has(value)) {
       return this.nodes.get(value);
-    } else {
-      const vertex = new Node(value);
-      this.nodes.set(value, vertex);
-      return vertex;
     }
+    const vertex = new Node(value);
+    this.nodes.set(value, vertex);
+    return vertex;
   }
 
   /**
@@ -55,10 +54,8 @@ class Graph {
    */
   removeVertex(value) {
     const current = this.nodes.get(value);
-    if(current) {
-      for (const node of this.nodes.values()) {
-        node.removeAdjacent(current);
-      }
+    if (current) {
+      Array.from(this.nodes.values()).forEach(node => node.removeAdjacent(current));
     }
     return this.nodes.delete(value);
   }
@@ -79,7 +76,7 @@ class Graph {
 
     sourceNode.addAdjacent(destinationNode);
 
-    if(this.edgeDirection === Graph.UNDIRECTED) {
+    if (this.edgeDirection === Graph.UNDIRECTED) {
       destinationNode.addAdjacent(sourceNode);
     }
 
@@ -99,10 +96,10 @@ class Graph {
     const sourceNode = this.nodes.get(source);
     const destinationNode = this.nodes.get(destination);
 
-    if(sourceNode && destinationNode) {
+    if (sourceNode && destinationNode) {
       sourceNode.removeAdjacent(destinationNode);
 
-      if(this.edgeDirection === Graph.UNDIRECTED) {
+      if (this.edgeDirection === Graph.UNDIRECTED) {
         destinationNode.removeAdjacent(sourceNode);
       }
     }
@@ -119,7 +116,7 @@ class Graph {
     const sourceNode = this.nodes.get(source);
     const destinationNode = this.nodes.get(destination);
 
-    if(sourceNode && destinationNode) {
+    if (sourceNode && destinationNode) {
       return sourceNode.isAdjacent(destinationNode);
     }
 
@@ -131,33 +128,33 @@ class Graph {
    * Use a stack to visit nodes (LIFO)
    * @param {Node} first node to start the dfs
    */
-  *dfs(first) {
-    yield* this._graphSearch(first, Stack);
+  * dfs(first) {
+    yield* this.graphSearch(first, Stack);
   }
 
   /**
    * Depth-first search
    * Use a queue to visit nodes (FIFO)
    * @param {Node} first node to start the dfs
    */
-  *bfs(first) {
-    yield* this._graphSearch(first, Queue);
+  * bfs(first) {
+    yield* this.graphSearch(first, Queue);
   }
 
   /**
    * Generic graph search where we can pass a Stack or Queue
    * @param {Node} first node to start the search
    * @param {Stack|Queue} dsType Stack for DFS or Queue for BFS
    */
-  *_graphSearch(first, dsType = Stack) {
+  * graphSearch(first, dsType = Stack) {
     const visited = new Map();
     const visitList = new dsType();
 
     visitList.add(first);
 
-    while(!visitList.isEmpty()) {
+    while (!visitList.isEmpty()) {
       const node = visitList.remove();
-      if(node && !visited.has(node)) {
+      if (node && !visited.has(node)) {
         yield node;
         visited.set(node);
         node.getAdjacents().forEach(adj => visitList.add(adj));
@@ -174,10 +171,10 @@ class Graph {
     const sourceNode = this.nodes.get(source);
     const destinationNode = this.nodes.get(destination);
 
-    if(sourceNode && destinationNode) {
+    if (sourceNode && destinationNode) {
       const bfsFromFirst = this.bfs(sourceNode);
       for (const node of bfsFromFirst) {
-        if(node === destinationNode) {
+        if (node === destinationNode) {
           return true;
         }
       }
@@ -201,15 +198,16 @@ class Graph {
 
     path.set(sourceNode);
 
+    // eslint-disable-next-line no-iterator
     for (const node of sourceNode.getAdjacents()) {
-      if(node === destinationNode) {
+      if (node === destinationNode) {
         path.set(destinationNode);
         return Array.from(path.keys());
       }
 
-      if(!path.has(node)) {
+      if (!path.has(node)) {
         const newPath = this.findPath(node.value, destination, path);
-        if(newPath.length) {
+        if (newPath.length) {
           return newPath;
         }
       }
@@ -222,4 +220,4 @@ class Graph {
 Graph.UNDIRECTED = Symbol('directed graph'); // one-way edges
 Graph.DIRECTED = Symbol('undirected graph'); // two-ways edges
 
-module.exports = Graph;
+module.exports = Graph;