Do not force constraint validation by setting them as 'not valid'

Author: madtibo

load_into_pg.py

@@ -150,7 +150,7 @@ def _getTableKeys(table):
         ]
     return keys
 
-def handleTable(table, keys, dbname, mbDbFile, mbHost, mbPort, mbUsername, mbPassword):
+def handleTable(table, insertJson, createFk, dbname, mbDbFile, mbHost, mbPort, mbUsername, mbPassword):
     """Handle the table including the post/pre processing."""
     keys       = _getTableKeys(table)
     dbFile     = mbDbFile if mbDbFile is not None else table + '.xml'
@@ -309,8 +309,8 @@ def handleTable(table, keys, dbname, mbDbFile, mbHost, mbPort, mbUsername, mbPas
     if not args.with_post_body:
         specialRules[('Posts', 'Body')] = 'NULL'
 
-choice = input('This will drop the {} table. Are you sure [y/n]?'.format(table))
+choice = input('This will drop the {} table. Are you sure [y/n]? '.format(table))
 if len(choice) > 0 and choice[0].lower() == 'y':
-    handleTable(table, keys, args.insert_json, args.dbname, args.file, args.host, args.port, args.username, args.password)
+    handleTable(table, args.insert_json, args.foreign_keys, args.dbname, args.file, args.host, args.port, args.username, args.password)
 else:
     six.print_("Cancelled.")

sql/PostLinks_fk.sql

@@ -1,5 +1,13 @@
--- impossible to enforce so set NULL
-UPDATE Postlinks SET postid=NULL WHERE postid NOT IN (SELECT DISTINCT id FROM Posts);
-ALTER TABLE Postlinks ADD CONSTRAINT fk_postlinks_postid FOREIGN KEY (postid) REFERENCES posts (id);
-UPDATE Postlinks SET relatedpostid=NULL WHERE relatedpostid NOT IN (SELECT DISTINCT id FROM Posts);
-ALTER TABLE Postlinks ADD CONSTRAINT fk_postlinks_relatedpostid FOREIGN KEY (relatedpostid) REFERENCES posts (id);
+-- impossible to enforce these constraints, set as 'not valid' to disable
+-- initial test.
+--
+-- These constaints can be forced running the following queries:
+-- ALTER TABLE postlinks ALTER postid DROP NOT NULL;
+-- UPDATE postlinks SET postid=NULL WHERE postid NOT IN (SELECT DISTINCT id FROM Posts);
+-- ALTER TABLE postlinks VALIDATE CONSTRAINT fk_postlinks_postid;
+-- ALTER TABLE postlinks ALTER relatedpostid DROP NOT NULL;
+-- UPDATE postlinks SET relatedpostid=NULL WHERE relatedpostid NOT IN (SELECT DISTINCT id FROM Posts);
+-- ALTER TABLE postlinks VALIDATE CONSTRAINT fk_postlinks_relatedpostid;
+--
+ALTER TABLE Postlinks ADD CONSTRAINT fk_postlinks_postid FOREIGN KEY (postid) REFERENCES posts (id) NOT VALID;
+ALTER TABLE Postlinks ADD CONSTRAINT fk_postlinks_relatedpostid FOREIGN KEY (relatedpostid) REFERENCES posts (id) NOT VALID;

sql/Votes_fk.sql

@@ -1,4 +1,10 @@
 ALTER TABLE Votes ADD CONSTRAINT fk_votes_userid FOREIGN KEY (userid) REFERENCES users (id);
--- impossible to enforce so set NULL
-UPDATE Votes SET postid=NULL WHERE postid NOT IN (SELECT DISTINCT id FROM Posts);
-ALTER TABLE Votes ADD CONSTRAINT fk_votes_postid FOREIGN KEY (postid) REFERENCES posts (id);
+-- impossible to enforce this constraint, set as 'not valid' to disable
+-- initial test.
+--
+-- This constaint can be forced running the following queries:
+-- ALTER TABLE votes ALTER PostId DROP NOT NULL;
+-- UPDATE votes SET postid=NULL WHERE postid NOT IN (SELECT DISTINCT id FROM Posts);
+-- ALTER TABLE votes VALIDATE CONSTRAINT fk_votes_postid;
+--
+ALTER TABLE Votes ADD CONSTRAINT fk_votes_postid FOREIGN KEY (postid) REFERENCES posts (id) NOT VALID;

sql/Votes_pre.sql

@@ -1,7 +1,7 @@
 DROP TABLE IF EXISTS Votes CASCADE;
 CREATE TABLE Votes (
    Id                int         PRIMARY KEY ,
-   PostId            int         , -- not NULL    ,
+   PostId            int         not NULL    ,
    VoteTypeId        int         not NULL    ,
    UserId            int                     ,
    CreationDate      timestamp   not NULL    ,