ignore invalid variable names during injection of global params

Author: Zolmeister

lib/getImportGlobalsSrc.js

@@ -26,10 +26,15 @@ function getImportGlobalsSrc(ignore) {
             continue;
         }
         value = globalObj[key];
-        src += "var " + key + " = global." + key + "; ";
+
+        // key may be an invalid variable name (e.g. 'a-b')
+        try {
+          eval("var " + key + ";");
+          src += "var " + key + " = global." + key + "; ";
+        } catch(e) {}
     }
 
     return src;
 }
 
-module.exports = getImportGlobalsSrc;
+module.exports = getImportGlobalsSrc;

test/getImportGlobalsSrc.test.js

@@ -17,11 +17,15 @@ describe("getImportGlobalsSrc", function () {
         global.exports = exports;
         global.require = require;
 
+        // Also make sure it ignores invalid variable names
+        global['a-b'] = true;
+
         src = getImportGlobalsSrc();
 
         delete global.module;
         delete global.exports;
         delete global.require;
+        delete global['a-b'];
 
         expectedGlobals = Object.keys(global);
 
@@ -63,4 +67,4 @@ describe("getImportGlobalsSrc", function () {
         expect(actualGlobals).to.eql(expectedGlobals);
         expect(actualGlobals.length).to.be.above(1);
     });
-});
+});