Skip to content

Conversation

@comewalk
Copy link
Contributor

This PR fixes #4664. It looks like the cause related to #4251.

Copy link
Contributor

@Meligy Meligy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just like how help works.

Can you add a test for this as well? It would be a copy-paste from the help test.

@comewalk
Copy link
Contributor Author

@Meligy Thank you for your suggestion. I added a test for completion. Could you review this?

Copy link
Contributor

@Meligy Meligy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks :)

@filipesilva
Copy link
Contributor

Thanks for fixing this @comewalk!

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng completion not working (Error: Cannot find module './build.d')

4 participants