Set installCerts value in config.ini if certicates are manually installed

Author: MatteoPologruto

config/config.go

@@ -21,6 +21,7 @@ import (
 	"os"
 
 	"github.com/arduino/go-paths-helper"
+	"github.com/go-ini/ini"
 	log "github.com/sirupsen/logrus"
 )
 
@@ -124,3 +125,20 @@ func GenerateConfig(destDir *paths.Path) *paths.Path {
 	log.Infof("generated config in %s", configPath)
 	return configPath
 }
+
+// SetInstallCertsIni sets installCerts value to true in the config
+func SetInstallCertsIni(filename string, value string) error {
+	cfg, err := ini.LoadSources(ini.LoadOptions{IgnoreInlineComment: false, AllowPythonMultilineValues: true}, filename)
+	if err != nil {
+		return err
+	}
+	_, err = cfg.Section("").NewKey("installCerts", value)
+	if err != nil {
+		return err
+	}
+	err = cfg.SaveTo(filename)
+	if err != nil {
+		return err
+	}
+	return nil
+}

main.go

@@ -228,7 +228,7 @@ func loop() {
 			log.Panicf("config.ini cannot be parsed: %s", err)
 		} else if !exist {
 			if cert.PromptInstallCertsSafari() {
-				err = modifyIni(configPath.String(), "true")
+				err = config.SetInstallCertsIni(configPath.String(), "true")
 				if err != nil {
 					log.Panicf("config.ini cannot be parsed: %s", err)
 				}
@@ -241,7 +241,7 @@ func loop() {
 					cert.DeleteCertificates(certDir)
 				}
 			} else {
-				err = modifyIni(configPath.String(), "false")
+				err = config.SetInstallCertsIni(configPath.String(), "false")
 				if err != nil {
 					log.Panicf("config.ini cannot be parsed: %s", err)
 				}
@@ -524,22 +524,6 @@ func parseIni(filename string) (args []string, err error) {
 	return args, nil
 }
 
-func modifyIni(filename string, value string) error {
-	cfg, err := ini.LoadSources(ini.LoadOptions{IgnoreInlineComment: false, AllowPythonMultilineValues: true}, filename)
-	if err != nil {
-		return err
-	}
-	_, err = cfg.Section("").NewKey("installCerts", value)
-	if err != nil {
-		return err
-	}
-	err = cfg.SaveTo(filename)
-	if err != nil {
-		return err
-	}
-	return nil
-}
-
 func installCertsKeyExists(filename string) (bool, error) {
 	cfg, err := ini.LoadSources(ini.LoadOptions{IgnoreInlineComment: false, AllowPythonMultilineValues: true}, filename)
 	if err != nil {

systray/systray_real.go

@@ -108,6 +108,10 @@ func (s *Systray) start() {
 					log.Errorf("cannot install certificates something went wrong: %s", err)
 					cert.DeleteCertificates(certDir)
 				}
+				err = config.SetInstallCertsIni(s.currentConfigFilePath.String(), "true")
+				if err != nil {
+					log.Errorf("cannot set installCerts value in config.ini: %s", err)
+				}
 				s.Restart()
 			case <-mRemoveCerts.ClickedCh:
 				err := cert.UninstallCertificates()