Commit 6d509d6
authored
fix: remote ide no longer reconnects after plugin upgrade (#167)
When the plugin is upgraded while JBClient is connected to a remote dev
server via the Coder SSH proxy/tunnel, the upgrade process kills and
re-establishes the SSH connection. However, JBClient/Toolbox fails to
detect the restored connection and reports "Toolbox: Target environment
com.coder.toolbox:bobiverse-bob.dev not found" error.
While digging into the Toolbox bytecode—specifically
`ClientOverSshTunnelConnector` — I realized the issue likely stems from
an incorrect equals implementation in our custom SSH connection info
object. In short, when a plugin upgrade terminates the SSH tunnel, the
connector’s monitoring logic correctly detects the lost connection and
waits. But when the SSH connection is re-established, the monitoring
logic fails to recognize it as a valid replacement, because equals is
still using the default `Object#equals` rather than a proper value-based
implementation.
Unfortunately, I wasn’t able to properly test this—specifically,
upgrading from a version without the fix to one that includes it—because
all Toolbox marketplace feeds are signed, preventing us from using a
tool like mitmproxy to serve a locally modified plugin version. Given
that, I propose releasing the change first and then performing the
upgrade test to confirm the fix.
- resolves #611 parent 5af07af commit 6d509d6
File tree
2 files changed
+50
-15
lines changed- src/main/kotlin/com/coder/toolbox/views
2 files changed
+50
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
| |||
Lines changed: 46 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
39 | 68 | | |
| 69 | + | |
| 70 | + | |
40 | 71 | | |
0 commit comments