refactor: simplify OAuth manager architecture and improve dependency injection

- remove ServiceLocator dependency from CoderToolboxContext
- move OAuth manager creation to CoderToolboxExtension for cleaner separation
- Refactor CoderOAuthManager to use configuration-based approach instead of constructor injection

The idea behind these changes is that createRefreshConfig API does not receive a configuration
object that can provide the client id and secret and even the refresh url. So initially
we worked around the issue by passing the necessary data via the constructor. However this approach
means a couple of things:

- the actual auth manager can be created only at a very late stage, when a URL is provided by users
- can't easily pass arround the auth manager without coupling the components
- have to recreate a new auth manager instance if the user logs out and logs in to a different URL
- service locator needs to be passed around because this is the actual factory of oauth managers in Toolbox

Instead, we went with a differet approach, COderOAuthManager will derive and store the refresh configs once
the authorization config is received. If the user logs out and logs in to a different URL the refresh data is
also guaranteed to be updated. And on top of that - this approach allows us to get rid of all of the issues
mentioned above.

Author: fioan89

src/main/kotlin/com/coder/toolbox/CoderToolboxContext.kt

@@ -2,11 +2,9 @@ package com.coder.toolbox
 
 import com.coder.toolbox.oauth.CoderAccount
 import com.coder.toolbox.oauth.CoderOAuthCfg
-import com.coder.toolbox.oauth.CoderOAuthManager
 import com.coder.toolbox.store.CoderSecretsStore
 import com.coder.toolbox.store.CoderSettingsStore
 import com.coder.toolbox.util.toURL
-import com.jetbrains.toolbox.api.core.ServiceLocator
 import com.jetbrains.toolbox.api.core.auth.PluginAuthManager
 import com.jetbrains.toolbox.api.core.diagnostics.Logger
 import com.jetbrains.toolbox.api.core.os.LocalDesktopManager
@@ -23,7 +21,7 @@ import java.util.UUID
 
 @Suppress("UnstableApiUsage")
 data class CoderToolboxContext(
-    private val serviceLocator: ServiceLocator,
+    val oauthManager: PluginAuthManager<CoderAccount, CoderOAuthCfg>,
     val ui: ToolboxUi,
     val envPageManager: EnvironmentUiPageManager,
     val envStateColorPalette: EnvironmentStateColorPalette,
@@ -53,14 +51,6 @@ data class CoderToolboxContext(
                 ?: settingsStore.defaultURL.toURL()
         }
 
-    fun getAuthManager(
-        cfg: CoderOAuthCfg
-    ): PluginAuthManager<CoderAccount, CoderOAuthCfg> = serviceLocator.getAuthManager(
-        accountClass = CoderAccount::class.java,
-        displayName = "Coder Authentication",
-        pluginAuthInterface = CoderOAuthManager(cfg)
-    )
-
     suspend fun logAndShowError(title: String, error: String) {
         logger.error(error)
         ui.showSnackbar(

src/main/kotlin/com/coder/toolbox/CoderToolboxExtension.kt

@@ -1,5 +1,7 @@
 package com.coder.toolbox
 
+import com.coder.toolbox.oauth.CoderAccount
+import com.coder.toolbox.oauth.CoderOAuthManager
 import com.coder.toolbox.settings.Environment
 import com.coder.toolbox.store.CoderSecretsStore
 import com.coder.toolbox.store.CoderSettingsStore
@@ -29,7 +31,11 @@ class CoderToolboxExtension : RemoteDevExtension {
         val logger = serviceLocator.getService(Logger::class.java)
         return CoderRemoteProvider(
             CoderToolboxContext(
-                serviceLocator,
+                serviceLocator.getAuthManager(
+                    CoderAccount::class.java,
+                    "Coder OAuth2 Manager",
+                    CoderOAuthManager()
+                ),
                 serviceLocator.getService<ToolboxUi>(),
                 serviceLocator.getService<EnvironmentUiPageManager>(),
                 serviceLocator.getService<EnvironmentStateColorPalette>(),

src/main/kotlin/com/coder/toolbox/oauth/CoderOAuthManager.kt

@@ -7,7 +7,9 @@ import com.jetbrains.toolbox.api.core.auth.OAuthToken
 import com.jetbrains.toolbox.api.core.auth.PluginAuthInterface
 import com.jetbrains.toolbox.api.core.auth.RefreshConfiguration
 
-class CoderOAuthManager(private val cfg: CoderOAuthCfg) : PluginAuthInterface<CoderAccount, CoderOAuthCfg> {
+class CoderOAuthManager : PluginAuthInterface<CoderAccount, CoderOAuthCfg> {
+    private lateinit var refreshConf: CoderRefreshConfig
+
     override fun serialize(account: CoderAccount): String = "${account.id}|${account.fullName}"
 
     override fun deserialize(string: String): CoderAccount = CoderAccount(
@@ -32,6 +34,7 @@ class CoderOAuthManager(private val cfg: CoderOAuthCfg) : PluginAuthInterface<Co
     override fun createAuthConfig(loginConfiguration: CoderOAuthCfg): AuthConfiguration {
         val codeVerifier = PKCEGenerator.generateCodeVerifier()
         val codeChallenge = PKCEGenerator.generateCodeChallenge(codeVerifier)
+        refreshConf = loginConfiguration.toRefreshConf()
 
         return AuthConfiguration(
             authParams = mapOf(
@@ -56,11 +59,11 @@ class CoderOAuthManager(private val cfg: CoderOAuthCfg) : PluginAuthInterface<Co
 
     override fun createRefreshConfig(account: CoderAccount): RefreshConfiguration {
         return object : RefreshConfiguration {
-            override val refreshUrl: String = cfg.tokenUrl
+            override val refreshUrl: String = refreshConf.refreshUrl
             override val parameters: Map<String, String> = mapOf(
                 "grant_type" to "refresh_token",
-                "client_id" to cfg.clientId,
-                "client_secret" to cfg.clientSecret
+                "client_id" to refreshConf.clientId,
+                "client_secret" to refreshConf.clientSecret
             )
             override val authorization: String? = null
             override val contentType: ContentType = FORM_URL_ENCODED
@@ -74,4 +77,16 @@ data class CoderOAuthCfg(
     val tokenUrl: String,
     val clientId: String,
     val clientSecret: String,
+)
+
+private data class CoderRefreshConfig(
+    val refreshUrl: String,
+    val clientId: String,
+    val clientSecret: String,
+)
+
+private fun CoderOAuthCfg.toRefreshConf() = CoderRefreshConfig(
+    refreshUrl = this.tokenUrl,
+    clientId = this.clientId,
+    this.clientSecret
 )