Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coder/coder-jetbrains-toolbox
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: coder/coder-jetbrains-toolbox
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: simplify-workspace-status-management
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Nov 21, 2025

  1. refactor: simplify workspace start status management 

    Current approach with a secondary poll loop that handles the start action
of a workspace is overengineered. Basically the problem is the CLI takes too
long before moving the workspace into the queued/starting state, during which
the user doesn't have any feedback. To address the issue we:
- stopped the main poll loop from updating the environment
- moved the environment in the queued state immediately after the start button was pushed.
- started a poll loop that moved the workspace from queued state to starting space only
after that state became available in the backend. The intermediary stopped state is skipped by
the secondary poll loop.

@asher pointed out that a better approach can be implemented. We already store the status, and workspace
and the agent in the environment. When the start comes in:
1. We directly update the env. status to "queued"
2. We only change the environment status if there is difference in the existing workspace&agent
status vs the status from the main poll loop
3. no secondary poll loop is needed.
    @fioan89
    fioan89 committed Nov 21, 2025
    Configuration menu
    Copy the full SHA
    7c64008 View commit details
    Browse the repository at this point in the history

  2. refactor: available actions refresh logic 

    And improved debug messages
    @fioan89
    fioan89 committed Nov 21, 2025
    Configuration menu
    Copy the full SHA
    62eea90 View commit details
    Browse the repository at this point in the history

  3. fix: hide start action after calling the CLI 

    Start action was still visible because the action list was not yet refreshed.
    @fioan89
    fioan89 committed Nov 21, 2025
    Configuration menu
    Copy the full SHA
    ea43cd4 View commit details
    Browse the repository at this point in the history
Loading