Skip to content

Commit 53577a7

Browse files
committed
Fix: terminal link for workspaces with a single agent
- resolves #65
1 parent d1b1ba0 commit 53577a7

File tree

3 files changed

+14
-23
lines changed

3 files changed

+14
-23
lines changed

CHANGELOG.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,26 @@
33
# coder-gateway Changelog
44

55
## [Unreleased]
6+
67
### Added
8+
79
- support for displaying workspace version
810
- support for managing the lifecycle of a workspace, i.e. start and stop
911

12+
### Fixed
13+
14+
- terminal link for workspaces with a single agent
15+
1016
### Changed
17+
1118
- workspace panel is now updated every 5 seconds
1219

1320
## [2.0.2]
21+
1422
### Added
15-
- support for displaying working and non-working workspaces
16-
- better support for Light and Dark themes in the "Status" column
1723

24+
- support for displaying working and non-working workspaces
25+
- better support for Light and Dark themes in the "Status" column
1826

1927
### Fixed
2028
- left panel is no longer visible when a new connection is triggered from Coder's "Recent Workspaces" panel.

src/main/kotlin/com/coder/gateway/views/steps/CoderLocateRemoteProjectStepView.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ class CoderLocateRemoteProjectStepView(private val disableNextAction: () -> Unit
111111

112112
tfProject.text = if (selectedWorkspace.homeDirectory.isNullOrBlank()) "/home" else selectedWorkspace.homeDirectory
113113
titleLabel.text = CoderGatewayBundle.message("gateway.connector.view.coder.remoteproject.choose.text", selectedWorkspace.name)
114-
terminalLink.url = "${coderClient.coderURL}/@${coderClient.me.username}/${selectedWorkspace.name}.coder/terminal"
114+
terminalLink.url = "${coderClient.coderURL}/@${coderClient.me.username}/${selectedWorkspace.name}/terminal"
115115

116116
cs.launch {
117117
logger.info("Retrieving available IDE's for ${selectedWorkspace.name} workspace...")

src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -348,37 +348,20 @@ class CoderWorkspacesStepView(val enableNextButtonCallback: (Boolean) -> Unit) :
348348
)
349349
}
350350

351-
1 -> {
352-
listOf(
353-
WorkspaceAgentModel(
354-
this.id,
355-
this.name,
356-
this.name,
357-
this.templateName,
358-
WorkspaceVersionStatus.from(this),
359-
WorkspaceAgentStatus.from(this),
360-
OS.from(agents[0].operatingSystem),
361-
Arch.from(agents[0].architecture),
362-
agents[0].directory
363-
)
364-
)
365-
}
366-
367351
else -> agents.map { agent ->
368-
val workspaceName = "${this.name}.${agent.name}"
352+
val workspaceWithAgentName = "${this.name}.${agent.name}"
369353
WorkspaceAgentModel(
370354
this.id,
371355
this.name,
372-
workspaceName,
356+
workspaceWithAgentName,
373357
this.templateName,
374358
WorkspaceVersionStatus.from(this),
375359
WorkspaceAgentStatus.from(this),
376360
OS.from(agent.operatingSystem),
377361
Arch.from(agent.architecture),
378362
agent.directory
379363
)
380-
}
381-
.toList()
364+
}.toList()
382365
}
383366
} catch (e: Exception) {
384367
logger.warn("Agent(s) for ${this.name} could not be retrieved. Reason: $e")

0 commit comments

Comments
 (0)