Commit 7cc85d2
authored
Revert platformVersion (#268)
If you run the latest plugin on Gateway 231 you get an error about
DeployWithDownload being void when the IDE is not already installed.
Reverting the platform version back to 231 makes the plugin work on both
231 and 232 (the current EAP).
Honestly I do not understand why this is necessary as the API here does
not appear to have changed at all.
Upon doing some research though it appears that the platform version
should match the "since build" version so I downgraded further. It
seems `minimumWidth` and `maximumWidth` are not available in that
version so our plugin is currently broken there as well. This is fixed
by using `size` instead.
I think normally the plugin verifier would catch these things and I
tried getting it working by specifying the versions to check but it
seems to be bugged; the only errors it shows appear to be from a failure
to properly resolve dependencies.1 parent 148240a commit 7cc85d2
File tree
3 files changed
+12
-6
lines changed- src/main/kotlin/com/coder/gateway/views
3 files changed
+12
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
153 | 157 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
13 | 17 | | |
14 | | - | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
| 21 | + | |
17 | 22 | | |
18 | 23 | | |
19 | 24 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
38 | 36 | | |
39 | 37 | | |
40 | 38 | | |
| |||
182 | 180 | | |
183 | 181 | | |
184 | 182 | | |
185 | | - | |
186 | | - | |
| 183 | + | |
187 | 184 | | |
188 | 185 | | |
189 | 186 | | |
| |||
0 commit comments