Skip to content

Commit 06c21d0

Browse files
committed
Add type declarations to class properties.
1 parent d3f56f7 commit 06c21d0

19 files changed

+52
-52
lines changed

src/php/admin-menus/class-admin-menu.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,35 +12,35 @@ abstract class Admin_Menu {
1212
*
1313
* @var string
1414
*/
15-
public $name;
15+
public string $name;
1616

1717
/**
1818
* The label shown in the admin menu.
1919
*
2020
* @var string
2121
*/
22-
public $label;
22+
public string $label;
2323

2424
/**
2525
* The text used for the page title.
2626
*
2727
* @var string
2828
*/
29-
public $title;
29+
public string $title;
3030

3131
/**
3232
* The base slug for the top-level admin menu.
3333
*
3434
* @var string
3535
*/
36-
protected $base_slug;
36+
protected string $base_slug;
3737

3838
/**
3939
* The slug for this admin menu.
4040
*
4141
* @var string
4242
*/
43-
protected $slug;
43+
protected string $slug;
4444

4545
/**
4646
* Constructor.

src/php/admin-menus/class-edit-menu.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class Edit_Menu extends Admin_Menu {
2525
* @var Snippet|null
2626
* @see Edit_Menu::load_snippet_data()
2727
*/
28-
protected $snippet = null;
28+
protected ?Snippet $snippet = null;
2929

3030
/**
3131
* Constructor

src/php/admin-menus/class-manage-menu.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ class Manage_Menu extends Admin_Menu {
1818
*
1919
* @var List_Table
2020
*/
21-
public $list_table;
21+
public List_Table $list_table;
2222

2323
/**
2424
* Instance of the cloud list table class for search results.
2525
*
2626
* @var Cloud_Search_List_Table
2727
*/
28-
public $cloud_search_list_table;
28+
public Cloud_Search_List_Table $cloud_search_list_table;
2929

3030
/**
3131
* Class constructor
@@ -211,7 +211,7 @@ public function enqueue_assets() {
211211
wp_set_script_translations( 'code-snippets-manage-js', 'code-snippets' );
212212

213213
if ( 'cloud_search' === $this->get_current_type() ) {
214-
Frontend::enqueue_all_prism_themes();
214+
Front_End::enqueue_all_prism_themes();
215215
}
216216
}
217217

src/php/admin-menus/class-welcome-menu.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class Welcome_Menu extends Admin_Menu {
4646
*
4747
* @var ?array
4848
*/
49-
private $welcome_data = null;
49+
private ?array $welcome_data = null;
5050

5151
/**
5252
* Class constructor

src/php/class-active-snippets.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class Active_Snippets {
1414
*
1515
* @var Snippet[]
1616
*/
17-
private $active_snippets = [];
17+
private array $active_snippets = [];
1818

1919
/**
2020
* Class constructor.

src/php/class-admin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class Admin {
1616
*
1717
* @var array<string, Admin_Menu>
1818
*/
19-
public $menus = array();
19+
public array $menus = array();
2020

2121
/**
2222
* Class constructor

src/php/class-contextual-help.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class Contextual_Help {
1818
*
1919
* @var WP_Screen
2020
*/
21-
public $screen;
21+
public WP_Screen $screen;
2222

2323
/**
2424
* Name of current screen
@@ -27,7 +27,7 @@ class Contextual_Help {
2727
*
2828
* @var string
2929
*/
30-
public $screen_name;
30+
public string $screen_name;
3131

3232
/**
3333
* Class constructor

src/php/class-data-item.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,21 @@ abstract class Data_Item {
1616
*
1717
* @var array<string, mixed>
1818
*/
19-
protected $fields;
19+
protected array $fields;
2020

2121
/**
2222
* List of default values provided for fields.
2323
*
2424
* @var array<string, mixed>
2525
*/
26-
protected $default_values;
26+
protected array $default_values;
2727

2828
/**
2929
* Optional list of field name aliases to map when resolving a field name.
3030
*
3131
* @var array<string, string> Field alias names keyed to actual field names.
3232
*/
33-
protected $field_aliases;
33+
protected array $field_aliases;
3434

3535
/**
3636
* Class constructor.

src/php/class-db.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ class DB {
2424
*
2525
* @var string
2626
*/
27-
public $table;
27+
public string $table;
2828

2929
/**
3030
* Network-wide table name.
3131
*
3232
* @var string
3333
*/
34-
public $ms_table;
34+
public string $ms_table;
3535

3636
/**
3737
* Class constructor.

src/php/class-list-table.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,28 +30,28 @@ class List_Table extends WP_List_Table {
3030
*
3131
* @var bool
3232
*/
33-
public $is_network;
33+
public bool $is_network;
3434

3535
/**
3636
* A list of statuses (views)
3737
*
3838
* @var array<string>
3939
*/
40-
public $statuses = [ 'all', 'active', 'inactive', 'recently_activated' ];
40+
public array $statuses = [ 'all', 'active', 'inactive', 'recently_activated' ];
4141

4242
/**
4343
* Column name to use when ordering the snippets list.
4444
*
4545
* @var string
4646
*/
47-
protected $order_by;
47+
protected string $order_by;
4848

4949
/**
5050
* Direction to use when ordering the snippets list. Either 'asc' or 'desc'.
5151
*
5252
* @var string
5353
*/
54-
protected $order_dir;
54+
protected string $order_dir;
5555

5656
/**
5757
* The constructor function for our class.

0 commit comments

Comments
 (0)