Respect coverage data's own filter when merging another source

Author: davedevelopment

src/CodeCoverage.php

@@ -349,7 +349,7 @@ public function merge(PHP_CodeCoverage $that)
     {
         foreach ($that->getData() as $file => $lines) {
             if (!isset($this->data[$file])) {
-                if (!$that->filter()->isFiltered($file)) {
+                if (!$that->filter()->isFiltered($file) && !$this->filter->isFiltered($file)) {
                     $this->data[$file] = $lines;
                 }
 

tests/PHP/CodeCoverageTest.php

@@ -317,6 +317,25 @@ public function testMerge2()
         );
     }
 
+    /**
+     * @covers PHP_CodeCoverage::getData
+     * @covers PHP_CodeCoverage::merge
+     */
+    public function testMergeRespectsTargetFilter()
+    {
+        $filter = new PHP_CodeCoverage_Filter;
+        $filter->addFileToWhitelist(TEST_FILES_PATH . 'BankAccount.php');
+
+        $coverage = $this->getCoverageForBankAccount($filter);
+
+        $coverage->merge($this->getCoverageForClassWithAnonymousFunction());
+
+        $this->assertEquals(
+            $this->getExpectedDataArrayForBankAccount(),
+            $coverage->getData()
+        );
+    }
+
     /**
      * @covers PHP_CodeCoverage::getLinesToBeIgnored
      */

tests/TestCase.php

@@ -74,7 +74,7 @@ protected function getXdebugDataForBankAccount()
         );
     }
 
-    protected function getCoverageForBankAccount()
+    protected function getCoverageForBankAccount(PHP_CodeCoverage_Filter $filter = null)
     {
         $data = $this->getXdebugDataForBankAccount();
 
@@ -88,7 +88,7 @@ protected function getCoverageForBankAccount()
                 $data[3]
             ));
 
-        $coverage = new PHP_CodeCoverage($stub, new PHP_CodeCoverage_Filter);
+        $coverage = new PHP_CodeCoverage($stub, $filter ?: new PHP_CodeCoverage_Filter);
 
         $coverage->start(
             new BankAccountTest('testBalanceIsInitiallyZero'),