Fix tests so they don't try to run "g"

Both new shell-related tests were causing the code under test to
split "git" into ["g", "i", "t"] and thus causing the code under
test to attempt to execute a "g" command. This passes the command
as a one-element list of strings rather than as a string, which
avoids this on all operating systems regardless of whether the code
under test has a bug being tested for.

This would not occur on Windows, which does not iterate commands of
type str character-by-character even when the command is run
without a shell. But it did happen on other systems.

Most of the time, the benefit of using a command that actually runs
"git" rather than "g" is the avoidance of confusion in the error
message. But this is also important because it is possible for the
user who runs the tests to have a "g" command, in which case it
could be very inconvenient, or even unsafe, to run "g". This should
be avoided even when the code under test has a bug that causes a
shell to be used when it shouldn't or not used when it should, so
having separate commands (list and str) per test case parameters
would not be a sufficient solution: it would only guard against
running "g" when a bug in the code under test were absent.

Author: EliahKagan

test/test_git.py

@@ -95,7 +95,7 @@ def test_it_uses_shell_or_not_as_specified(self, case, mock_popen):
         with mock.patch.object(Git, "USE_SHELL", value_from_class):
             with contextlib.suppress(GitCommandError):
                 self.git.execute(
-                    "git",  # No args, so it runs with or without a shell, on all OSes.
+                    ["git"],  # No args, so it runs with or without a shell, on all OSes.
                     shell=value_in_call,
                 )
 
@@ -112,7 +112,7 @@ def test_it_logs_if_it_uses_a_shell(self, case, mock_popen):
             with mock.patch.object(Git, "USE_SHELL", value_from_class):
                 with contextlib.suppress(GitCommandError):
                     self.git.execute(
-                        "git",  # No args, so it runs with or without a shell, on all OSes.
+                        ["git"],  # No args, so it runs with or without a shell, on all OSes.
                         shell=value_in_call,
                     )