util: close lockfile after opening successfully

skshetry · skshetry · commit 3e829eb516a6 · 2023-09-02T14:24:56.000+05:45
Otherwise, this will leak file handles and can be a problem in Windows. Also, `closefd=true` is the default here, so need to pass it explicitly. Regression from #1619. I noticed after [our tests started raising `ResourceWarning`][1]. ```python Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/git/util.py", line 938, in _obtain_lock_or_raise open(lock_file, mode='w', closefd=True) ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/pytest-of-runner/pytest-0/popen-gw0/external0/project.git/.git/config.lock' mode='w' encoding='UTF-8'> ``` [1]: https://github.com/iterative/dvc/actions/runs/6055520480/job/16434544764#step:6:869
diff --git a/git/util.py b/git/util.py
@@ -935,7 +935,8 @@ def _obtain_lock_or_raise(self) -> None:
             )
 
         try:
-            open(lock_file, mode='w', closefd=True)
+            with open(lock_file, mode='w'):
+                pass
         except OSError as e:
             raise IOError(str(e)) from e
 

Original file line number	Diff line number	Diff line change
`@@ -935,7 +935,8 @@ def _obtain_lock_or_raise(self) -> None:`
`935`	`935`	`)`
`936`	`936`
`937`	`937`	`try:`
`938`		`- open(lock_file, mode='w', closefd=True)`
	`938`	`+ with open(lock_file, mode='w'):`
	`939`	`+ pass`
`939`	`940`	`except OSError as e:`
`940`	`941`	`raise IOError(str(e)) from e`
`941`	`942`