Commit 78d63d9
committed
Let close_fds be True on all platforms
Since Python 3.7, subprocess.Popen supports close_fds=True on all
platforms, including Windows, and it is the default, including
when arguments for standard streams have non-None values passed.
3.7 is the lowest version of Python that GitPython supports. So
this omits the close_fds=True argument from the calls where it was
present. This has the same effect (in 3.7 and higher) as passing
close_fds=True.
When the the close_fd argument was added to the Popen call in
git.cmd.Git.execute in 1ee2afb, Python 2 was still supported. In
Python 2, close_fds defaulted to False. This appears to be the
reason it had been passed explicitly. It was conditioned on being
on a Unix-like system because having it True on Windows would
prevent stdin, stdout, or stderr redirection.1 parent 96acc22 commit 78d63d9
2 files changed
+0
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1001 | 1001 | | |
1002 | 1002 | | |
1003 | 1003 | | |
1004 | | - | |
1005 | 1004 | | |
1006 | 1005 | | |
1007 | 1006 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
106 | 105 | | |
107 | 106 | | |
108 | 107 | | |
| |||
0 commit comments