cmd: better support for bare repositories

In order to avoid the expense of parsing .git/config
just to know whether or not a repository is bare
at __init__ time, we just pass an optional flag to
Git.__init__():
	bare_repo with a default value of False.

Repo.init_bare() was updated to pass this flag.

We could have an optional Git.read_bare_status() function
that does the expensive lookup.  Then, users can optionally
call it at runtime if they really need to know whether or not
a repository is bare.  That seems like a decent tradeoff between
speed, correctness, and common use cases.

Signed-off-by: David Aguilar <davvid@gmail.com>

Author: davvid

lib/git/cmd.py

@@ -12,20 +12,21 @@ class Git(MethodMissingMixin):
     """
     The Git class manages communication with the Git binary
     """
-    def __init__(self, git_dir=None):
+    def __init__(self, git_dir=None, bare_repo=False):
         super(Git, self).__init__()
         if git_dir:
             self._location = os.path.abspath(git_dir)
         else:
             self._location = os.getcwd()
+        self._is_bare_repo = bare_repo
         self.refresh()
 
     def refresh(self):
         self._git_dir = None
         self._is_in_repo = not not self.get_git_dir()
         self._work_tree = None
         self._cwd = self._git_dir
-        if self._git_dir:
+        if self._git_dir and not self._is_bare_repo:
             self._cwd = self.get_work_tree()
 
     def _is_git_dir(self, d):
@@ -61,6 +62,8 @@ def get_git_dir(self):
         return self._git_dir
 
     def get_work_tree(self):
+        if self._is_bare_repo:
+            return None
         if not self._work_tree:
             self._work_tree = os.getenv('GIT_WORK_TREE')
             if not self._work_tree or not os.path.isdir(self._work_tree):

lib/git/repo.py

@@ -280,7 +280,7 @@ def init_bare(self, path, mkdir=True, **kwargs):
         if mkdir and not os.path.exists(path):
             os.makedirs(path, 0755)
 
-        git = Git(path)
+        git = Git(path, bare_repo=True)
         output = git.init(**kwargs)
         return Repo(path)
     create = init_bare