Use union types

Author: sebastianbergmann

.psalm/baseline.xml

@@ -203,10 +203,7 @@
     <PossiblyUndefinedMethod occurrences="1">
       <code>toString</code>
     </PossiblyUndefinedMethod>
-    <RedundantConditionGivenDocblockType occurrences="13">
-      <code>$node instanceof Function_</code>
-      <code>$node instanceof Function_</code>
-      <code>$type instanceof ComplexType</code>
+    <RedundantConditionGivenDocblockType occurrences="10">
       <code>assert($node-&gt;namespacedName instanceof Name)</code>
       <code>assert($node-&gt;namespacedName instanceof Name)</code>
       <code>assert($node-&gt;namespacedName instanceof Name)</code>

src/StaticAnalysis/CodeUnitFindingVisitor.php

@@ -106,13 +106,8 @@ public function functions(): array
         return $this->functions;
     }
 
-    /**
-     * @psalm-param ClassMethod|Function_ $node
-     */
-    private function cyclomaticComplexity(Node $node): int
+    private function cyclomaticComplexity(ClassMethod|Function_ $node): int
     {
-        assert($node instanceof ClassMethod || $node instanceof Function_);
-
         $nodes = $node->getStmts();
 
         if ($nodes === null) {
@@ -131,13 +126,8 @@ private function cyclomaticComplexity(Node $node): int
         return $cyclomaticComplexityCalculatingVisitor->cyclomaticComplexity();
     }
 
-    /**
-     * @psalm-param ClassMethod|Function_ $node
-     */
-    private function signature(Node $node): string
+    private function signature(ClassMethod|Function_ $node): string
     {
-        assert($node instanceof ClassMethod || $node instanceof Function_);
-
         $signature  = ($node->returnsByRef() ? '&' : '') . $node->name->toString() . '(';
         $parameters = [];
 
@@ -168,13 +158,8 @@ private function signature(Node $node): string
         return $signature;
     }
 
-    /**
-     * @psalm-param Identifier|Name|ComplexType $type
-     */
-    private function type(Node $type): string
+    private function type(Identifier|Name|ComplexType $type): string
     {
-        assert($type instanceof Identifier || $type instanceof Name || $type instanceof ComplexType);
-
         if ($type instanceof NullableType) {
             return '?' . $type->type;
         }