Refactor: break down login function.

Signed-off-by: Eric Wang <skygragon@gmail.com>

Author: skygragon

lib/plugins/leetcode.js

@@ -364,8 +364,8 @@ plugin.getFavorites = function(cb) {
   });
 };
 
-plugin.login = function(user, cb) {
-  log.debug('running leetcode.login');
+plugin.signin = function(user, cb) {
+  log.debug('running leetcode.signin');
   request(config.sys.urls.login, function(e, resp, body) {
     e = checkError(e, resp, 200);
     if (e) return cb(e);
@@ -393,19 +393,27 @@ plugin.login = function(user, cb) {
       user.sessionId = h.getSetCookieValue(resp, 'LEETCODE_SESSION');
       user.name = h.getSetCookieValue(resp, 'messages')
                    .match('Successfully signed in as ([^.]*)')[1];
-      session.saveUser(user);
+      return cb(null, user);
+    });
+  });
+};
 
-      plugin.getFavorites(function(e, favorites) {
-        if (e) return cb(e);
+plugin.login = function(user, cb) {
+  log.debug('running leetcode.login');
+  plugin.signin(user, function(e, user) {
+    if (e) return cb(e);
+    session.saveUser(user);
 
-        // TODO: pick other useful values from favorites
-        var favorite = _.find(favorites.favorites.private_favorites, function(f) {
-          return f.name === 'Favorite';
-        });
-        user.hash = favorite.id_hash;
+    plugin.getFavorites(function(e, favorites) {
+      if (e) return cb(e);
 
-        return cb(null, user);
+      // TODO: pick other useful values from favorites
+      var favorite = _.find(favorites.favorites.private_favorites, function(f) {
+        return f.name === 'Favorite';
       });
+      user.hash = favorite.id_hash;
+
+      return cb(null, user);
     });
   });
 };