[Plugin] Add more UTs.

Signed-off-by: Eric Wang <skygragon@gmail.com>

Author: skygragon

.gitignore

@@ -37,4 +37,5 @@ jspm_packages
 .node_repl_history
 
 tmp/
+*.swp
 .DS_Store

lib/core.js

@@ -26,7 +26,8 @@ core.getProblem = function(keyword, cb) {
         if (!user.paid && x.locked) return false;
         return true;
       });
-      problem = problems[_.random(problems.length - 1)];
+      if (problems.length > 0)
+        problem = problems[_.random(problems.length - 1)];
     } else {
       problem = _.find(problems, function(x) {
         return x.id === keyword || x.name === keyword || x.slug === keyword;

test/plugins/test_cache.js

@@ -32,6 +32,7 @@ describe('plugin:cache', function() {
   before(function() {
     log.init();
     config.init();
+    plugin.init();
 
     h.getHomeDir = function() {
       return HOME;

test/plugins/test_leetcode.js

@@ -30,6 +30,7 @@ describe('plugin:leetcode', function() {
   before(function() {
     log.init();
     config.init();
+    plugin.init();
 
     session.getUser = function() {
       return USER;
@@ -97,6 +98,47 @@ describe('plugin:leetcode', function() {
   }); // #login
 
   describe('#getProblems', function() {
+    it('should ok', function(done) {
+      nock('https://leetcode.com')
+        .get('/api/problems/algorithms/')
+        .replyWithFile(200, './test/mock/problems.json.20160911');
+
+      nock('https://leetcode.com')
+        .get('/api/problems/database/')
+        .replyWithFile(200, './test/mock/problems.json.20160911');
+
+      nock('https://leetcode.com')
+        .get('/api/problems/shell/')
+        .replyWithFile(200, './test/mock/problems.json.20160911');
+
+      plugin.getProblems(function(e, problems) {
+        assert.equal(e, null);
+        assert.equal(problems.length, 377 * 3);
+        done();
+      });
+    });
+
+    it('should fail if error occurs', function(done) {
+      nock('https://leetcode.com')
+        .get('/api/problems/algorithms/')
+        .replyWithFile(200, './test/mock/problems.json.20160911');
+
+      nock('https://leetcode.com')
+        .get('/api/problems/database/')
+        .replyWithError('unknown error');
+
+      nock('https://leetcode.com')
+        .get('/api/problems/shell/')
+        .replyWithFile(200, './test/mock/problems.json.20160911');
+
+      plugin.getProblems(function(e, problems) {
+        assert.equal(e.message, 'unknown error');
+        done();
+      });
+    });
+  }); // #getProblems
+
+  describe('#getCategoryProblems', function() {
     it('should ok', function(done) {
       nock('https://leetcode.com')
         .get('/api/problems/algorithms/')
@@ -301,7 +343,29 @@ describe('plugin:leetcode', function() {
       });
     });
 
+    it('should fail if session expired', function(done) {
+      nock('https://leetcode.com')
+        .get('/problems/find-the-difference')
+        .reply(403);
+
+      plugin.getProblem(PROBLEM, function(e, problem) {
+        assert.equal(e, session.errors.EXPIRED);
+        done();
+      });
+    });
+
     it('should fail if http error', function(done) {
+      nock('https://leetcode.com')
+        .get('/problems/find-the-difference')
+        .reply(500);
+
+      plugin.getProblem(PROBLEM, function(e, problem) {
+        assert.deepEqual(e, {msg: 'http error', statusCode: 500});
+        done();
+      });
+    });
+
+    it('should fail if unknown error', function(done) {
       nock('https://leetcode.com')
         .get('/problems/find-the-difference')
         .replyWithError('unknown error!');

test/test_config.js

@@ -15,7 +15,11 @@ describe('config', function() {
 
     var expect = config.getDefaultConfig();
     var actual = _.extendOwn({}, config); // remove 'init' function
-    assert.equal(_.isEqual(actual, expect), true);
+    assert.deepEqual(actual, expect);
+
+    expect = config.getUserConfig();
+    actual = config.__get__('DEFAULT_USER_CONFIG');
+    assert.deepEqual(actual, expect);
   });
 
   it('should ok w/ local config', function() {
@@ -37,6 +41,11 @@ describe('config', function() {
     var expect = config.getDefaultConfig();
     var actual = _.extendOwn({}, config); // remove 'init' function
     _.extendOwn(expect, localConfig);
-    assert.equal(_.isEqual(actual, expect), true);
+    assert.deepEqual(actual, expect);
+
+    expect = config.getUserConfig();
+    actual = config.__get__('DEFAULT_USER_CONFIG');
+    _.extendOwn(actual, localConfig);
+    assert.deepEqual(actual, expect);
   });
 });

test/test_core.js

@@ -216,6 +216,22 @@ describe('core', function() {
       });
     });
 
+    it('should getProblem random ok', function(done) {
+      NEXT.getProblems = function(cb) {
+        return cb(null, [
+          {id: 0, state: 'ac', locked: false},
+          {id: 1, state: 'none', locked: true},
+          {id: 2, state: 'none', locked: false}
+        ]);
+      };
+
+      plugin.getProblem(undefined, function(e, problem) {
+        assert.equal(e, null);
+        assert.equal(problem.id, 2);
+        done();
+      });
+    });
+
     it('should getProblem fail if getProblems error', function(done) {
       NEXT.getProblems = function(cb) {
         return cb('getProblems error');

test/test_helper.js

@@ -167,6 +167,14 @@ describe('helper', function() {
       process.env.USERPROFILE = 'C:\\Users\\skygragon';
       assert.equal(h.getHomeDir(), 'C:\\Users\\skygragon');
     });
+
+    it('should getDirData ok', function() {
+      var files = h.getDirData(['lib', 'plugins']);
+      assert.equal(files.length, 3);
+      assert.equal(files[0].name, 'cache');
+      assert.equal(files[1].name, 'leetcode');
+      assert.equal(files[2].name, 'retry');
+    });
   }); // #dirAndFiles
 
   describe('#getSetCookieValue', function() {

test/test_plugin.js

@@ -0,0 +1,46 @@
+var _ = require('underscore');
+var assert = require('chai').assert;
+var rewire = require('rewire');
+
+var log = require('../lib/log');
+var Plugin = rewire('../lib/plugin');
+var h = rewire('../lib/helper');
+
+describe('plugin', function() {
+  var cache = new Plugin('cache', 'Cache', '1.0', '');
+  var leetcode = new Plugin('leetcode', 'Leetcode', '2.0', '');
+  var retry = new Plugin('retry', 'Retry', '3.0', '');
+  var core = new Plugin('core', 'Core', '4.0', '');
+
+  before(function() {
+    log.init();
+
+    var noop = function() {};
+    cache.init = noop;
+    leetcode.init = noop;
+    retry.init = noop;
+    core.init = noop;
+
+    h.getDirData = function() {
+      return [
+        {name: 'cache', data: cache},
+        {name: 'leetcode', data: leetcode},
+        {name: 'retry', data: retry},
+        {name: 'core', data: core},
+        {name: 'bad', data: null}
+      ];
+    };
+    Plugin.__set__('h', h);
+  });
+
+  it('should init ok', function() {
+    assert.deepEqual(_.keys(Plugin.plugins), []);
+    Plugin.init(core);
+    assert.deepEqual(_.keys(Plugin.plugins), ['cache', 'leetcode', 'retry', 'core']);
+
+    assert.equal(core.next, retry);
+    assert.equal(retry.next, cache);
+    assert.equal(cache.next, leetcode);
+    assert.equal(leetcode.next, null);
+  });
+});