Merge pull request #13 from Asgrim/change-getParent-error-to-exception

chobie · chobie · commit 6bb5af40fc93 · 2011-08-02T07:39:04.000-07:00
Convert getParent error into exception for easier catching
diff --git a/src/commit.c b/src/commit.c
@@ -359,7 +359,7 @@ PHP_METHOD(git_commit, getParent)
     
     ret = git_commit_parent(&commit, this->object,offset);
     if(ret != GIT_SUCCESS){
-        php_error_docref(NULL TSRMLS_CC, E_ERROR, "specified offset not found.");
+        zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC, "specified offset not found");
         RETURN_FALSE;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ PHP_METHOD(git_commit, getParent)`
`359`	`359`
`360`	`360`	`ret = git_commit_parent(&commit, this->object,offset);`
`361`	`361`	`if(ret != GIT_SUCCESS){`
`362`		`- php_error_docref(NULL TSRMLS_CC, E_ERROR, "specified offset not found.");`
	`362`	`+ zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC, "specified offset not found");`
`363`	`363`	`RETURN_FALSE;`
`364`	`364`	`}`
`365`	`365`