repo.is_dirty: fixed incorrect check of a dirty working tree, previously it would compare HEAD against the working tree, not the index which was intended

Author: Byron

TODO

@@ -59,5 +59,12 @@ Tree
   testing whether it raises on invalid input ? ). See 6dc7799d44e1e5b9b77fd19b47309df69ec01a99
 * Derive from Iterable, simple pipe it through to Commit objects and iterate using 
   commit.tree.
+  
+Testing
+-------
+* Create a test-repository that can be written to and changed in addition to the normal 
+  read-only testing scheme that operates on the own repository. Doing this could be a simple
+  as forking a shared repo in a tmp directory. In that moment, we probably want to 
+  facility committing and checkouts as well.
 
 

lib/git/repo.py

@@ -432,11 +432,13 @@ def is_dirty(self, index=True, working_tree=True, untracked_files=False):
 		# start from the one which is fastest to evaluate
 		default_args = ('--abbrev=40', '--full-index', '--raw')
 		if index: 
+			# diff index against HEAD
 			if len(self.git.diff('HEAD', '--cached', *default_args)):
 				return True
 		# END index handling
 		if working_tree:
-			if len(self.git.diff('HEAD', *default_args)):
+			# diff index against working tree
+			if len(self.git.diff(*default_args)):
 				return True
 		# END working tree handling
 		if untracked_files: