diff method now checks for git-diff errrs that can easily occour if the repository is bare and if there is no index or second tree specified

Author: Byron

lib/git/diff.py

@@ -6,7 +6,7 @@
 
 import re
 import objects.blob as blob
-
+from errors import GitCommandError
 
 class Diffable(object):
 	"""
@@ -26,15 +26,17 @@ class Diffable(object):
 	class Index(object):
 		pass 
 
-	def diff(self, other=None, paths=None, create_patch=False, **kwargs):
+	def diff(self, other=Index, paths=None, create_patch=False, **kwargs):
 		"""
 		Creates diffs between two items being trees, trees and index or an 
 		index and the working tree.
 
 		``other``
 			Is the item to compare us with. 
 			If None, we will be compared to the working tree.
-			If Index ( type ), it will be compared against the index
+			If Index ( type ), it will be compared against the index.
+			It defaults to Index to assure the method will not by-default fail
+			on bare repositories.
 
 		``paths``
 			is a list of paths or a single path to limit the diff to.
@@ -53,7 +55,10 @@ def diff(self, other=None, paths=None, create_patch=False, **kwargs):
 			git.DiffIndex
 			
 		Note
-			Rename detection will only work if create_patch is True
+			Rename detection will only work if create_patch is True.
+			
+			On a bare repository, 'other' needs to be provided as Index or as 
+			as Tree/Commit, or a git command error will occour
 		"""
 		args = list(self._diff_args[:])
 		args.append( "--abbrev=40" )		# we need full shas
@@ -87,7 +92,13 @@ def diff(self, other=None, paths=None, create_patch=False, **kwargs):
 		diff_method = Diff._index_from_raw_format
 		if create_patch:
 			diff_method = Diff._index_from_patch_format
-		return diff_method(self.repo, proc.stdout)
+		index = diff_method(self.repo, proc.stdout)
+		
+		status = proc.wait()
+		if status != 0:
+			raise GitCommandError("git-diff", status, proc.stderr )
+		
+		return index
 
 
 class DiffIndex(list):

test/testlib/helper.py

@@ -52,3 +52,9 @@ def next(self):
 
 	def __init__(self, input_list_or_string):
 		self.stdout = self.Stream(input_list_or_string)
+		self.stderr = self.Stream('')
+		
+	def wait(self):
+		return 0
+		
+	poll = wait