fix(cmd): prevent deadlock on clone/fetch/pull

We keep stdout closed, which seems to have the side-effect of
stdout being connected to your TTY, in case you run a terminal.

However, this shold also prevent deadlocks, as only stderr is used.
The alternative would have been to try to fetch lines concurrently,
and we have been there.

For clone(), `communicate()` is used, and with some luck this will
just do the right thing. Even though last time I checked, it
didn't ... ? Lets see.

Stab at gitpython-developers#72

Author: Byron

git/cmd.py

@@ -279,8 +279,10 @@ def __del__(self):
             self.proc = None
             if proc.stdin:
                 proc.stdin.close()
-            proc.stdout.close()
-            proc.stderr.close()
+            if proc.stdout:
+                proc.stdout.close()
+            if proc.stderr:
+                proc.stderr.close()
 
             # did the process finish already so we have a return code ?
             if proc.poll() is not None:

git/config.py

@@ -160,14 +160,7 @@ class GitConfigParser(with_metaclass(MetaParserBuilder, cp.RawConfigParser, obje
 
     OPTVALUEONLY = re.compile(optvalueonly_source)
 
-    OPTCRE = re.compile(
-        optvalueonly_source                          # very permissive, incuding leading whitespace
-        + r'\s*(?P<vi>[:=])\s*'               # any number of space/tab,
-                                              # followed by separator
-                                              # (either : or =), followed
-                                              # by any # space/tab
-        + r'(?P<value>.*)$'                     # everything up to eol
-    )
+    OPTCRE = re.compile(optvalueonly_source + r'\s*(?P<vi>[:=])\s*' + r'(?P<value>.*)$')
 
     del optvalueonly_source
 

git/remote.py

@@ -650,7 +650,7 @@ def fetch(self, refspec=None, progress=None, **kwargs):
         else:
             args = [refspec]
 
-        proc = self.repo.git.fetch(self, *args, with_extended_output=True, as_process=True, with_stdout=False, v=True,
+        proc = self.repo.git.fetch(self, *args, as_process=True, with_stdout=False, v=True,
                                    **kwargs)
         res = self._get_fetch_info_from_stderr(proc, progress or RemoteProgress())
         if hasattr(self.repo.odb, 'update_cache'):
@@ -667,7 +667,7 @@ def pull(self, refspec=None, progress=None, **kwargs):
         :return: Please see 'fetch' method """
         self._assert_refspec()
         kwargs = add_progress(kwargs, self.repo.git, progress)
-        proc = self.repo.git.pull(self, refspec, with_extended_output=True, as_process=True, v=True, **kwargs)
+        proc = self.repo.git.pull(self, refspec, with_stdout=False, as_process=True, v=True, **kwargs)
         res = self._get_fetch_info_from_stderr(proc, progress or RemoteProgress())
         if hasattr(self.repo.odb, 'update_cache'):
             self.repo.odb.update_cache()