Eliminate coupling to PHPUnit_Util_Printer

sebastianbergmann · sebastianbergmann · commit b0ec2d014fe4 · 2013-05-07T15:59:06.000+02:00
diff --git a/PHP/CodeCoverage/Report/Text.php b/PHP/CodeCoverage/Report/Text.php
@@ -58,7 +58,6 @@
  */
 class PHP_CodeCoverage_Report_Text
 {
-    protected $outputStream;
     protected $lowUpperBound;
     protected $highLowerBound;
     protected $showUncoveredFiles;
@@ -72,9 +71,8 @@ class PHP_CodeCoverage_Report_Text
       'eol'    => "\x1b[2K",
     );
 
-    public function __construct(PHPUnit_Util_Printer $outputStream, $lowUpperBound, $highLowerBound, $showUncoveredFiles)
+    public function __construct($lowUpperBound, $highLowerBound, $showUncoveredFiles)
     {
-        $this->outputStream       = $outputStream;
         $this->lowUpperBound      = $lowUpperBound;
         $this->highLowerBound     = $highLowerBound;
         $this->showUncoveredFiles = $showUncoveredFiles;
@@ -245,7 +243,7 @@ public function process(PHP_CodeCoverage $coverage, $showColors = FALSE)
             }
         }
 
-        $this->outputStream->write($output . PHP_EOL);
+        return $output . PHP_EOL;
     }
 
     protected function getCoverageColor($numberOfCoveredElements, $totalNumberOfElements)

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,6 @@`
`58`	`58`	`*/`
`59`	`59`	`class PHP_CodeCoverage_Report_Text`
`60`	`60`	`{`
`61`		`- protected $outputStream;`
`62`	`61`	`protected $lowUpperBound;`
`63`	`62`	`protected $highLowerBound;`
`64`	`63`	`protected $showUncoveredFiles;`
`@@ -72,9 +71,8 @@ class PHP_CodeCoverage_Report_Text`
`72`	`71`	`'eol' => "\x1b[2K",`
`73`	`72`	`);`
`74`	`73`
`75`		`- public function __construct(PHPUnit_Util_Printer $outputStream, $lowUpperBound, $highLowerBound, $showUncoveredFiles)`
	`74`	`+ public function __construct($lowUpperBound, $highLowerBound, $showUncoveredFiles)`
`76`	`75`	`{`
`77`		`- $this->outputStream = $outputStream;`
`78`	`76`	`$this->lowUpperBound = $lowUpperBound;`
`79`	`77`	`$this->highLowerBound = $highLowerBound;`
`80`	`78`	`$this->showUncoveredFiles = $showUncoveredFiles;`
`@@ -245,7 +243,7 @@ public function process(PHP_CodeCoverage $coverage, $showColors = FALSE)`
`245`	`243`	`}`
`246`	`244`	`}`
`247`	`245`
`248`		`- $this->outputStream->write($output . PHP_EOL);`
	`246`	`+ return $output . PHP_EOL;`
`249`	`247`	`}`
`250`	`248`
`251`	`249`	`protected function getCoverageColor($numberOfCoveredElements, $totalNumberOfElements)`