Reduced dependency to voryx/Thruway

Author: Mathieu Lemoine

RunCommandProcessor.php

@@ -34,7 +34,11 @@ public function process(Message $message, Context $context): Result
         $phpBin = (new PhpExecutableFinder())->find();
         $consoleBin = file_exists($this->projectDir.'/bin/console') ? './bin/console' : './app/console';
 
-        $process = new Process($phpBin.' '.$consoleBin.' '.$this->getCommandLine($command), $this->projectDir);
+        $process = new Process(array_merge(
+            [$phpBin, $consoleBin, $command->getCommand()],
+            $command->getArguments(),
+            $this->getCommandLineOptions($command)
+        ), $this->projectDir);
         $process->setTimeout($this->timeout);
         $process->run();
 
@@ -48,22 +52,15 @@ public function process(Message $message, Context $context): Result
     }
 
     /**
-     * @return string
+     * @return string[]
      */
-    private function getCommandLine(RunCommand $command): string
+    private function getCommandLineOptions(RunCommand $command): array
     {
-        $optionsString = '';
+        $options = [];
         foreach ($command->getOptions() as $name => $value) {
-            $optionsString .= " $name=$value";
+            $options[] = "$name=$value";
         }
-        $optionsString = trim($optionsString);
 
-        $argumentsString = '';
-        foreach ($command->getArguments() as $value) {
-            $argumentsString .= " $value";
-        }
-        $argumentsString = trim($argumentsString);
-
-        return trim($command->getCommand().' '.$argumentsString.' '.$optionsString);
+        return $options;
     }
 }

composer.json

@@ -13,11 +13,12 @@
         "symfony/process": "^3.4|^4|^5"
     },
     "require-dev": {
-        "phpunit/phpunit": "~5.5",
+        "phpunit/phpunit": "~7.5",
         "symfony/dependency-injection": "^3.4|^4|^5",
         "symfony/config": "^3.4|^4|^5",
         "symfony/http-kernel": "^3.4|^4|^5",
         "symfony/filesystem": "^3.4|^4|^5",
+        "symfony/yaml": "^3.4|^4|^5",
         "enqueue/null": "0.9.x-dev",
         "enqueue/fs": "0.9.x-dev",
         "enqueue/test": "0.9.x-dev"