Skip to content

Commit fd2ea3f

Browse files
sebastianbergmannsebastianbergmann
committed
Merge branch 'master' into feature/path-coverage
2 parents cac073f + ac9bed8 commit fd2ea3f

File tree

18 files changed

+152
-154
lines changed

18 files changed

+152
-154
lines changed

‎src/CodeCoverage.php‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,32 +28,32 @@ class PHP_CodeCoverage
2828
private $filter;
2929

3030
/**
31-
* @var boolean
31+
* @var bool
3232
*/
3333
private $cacheTokens = false;
3434

3535
/**
36-
* @var boolean
36+
* @var bool
3737
*/
3838
private $checkForUnintentionallyCoveredCode = false;
3939

4040
/**
41-
* @var boolean
41+
* @var bool
4242
*/
4343
private $forceCoversAnnotation = false;
4444

4545
/**
46-
* @var boolean
46+
* @var bool
4747
*/
4848
private $mapTestClassNameToCoveredClassName = false;
4949

5050
/**
51-
* @var boolean
51+
* @var bool
5252
*/
5353
private $addUncoveredFilesFromWhitelist = true;
5454

5555
/**
56-
* @var boolean
56+
* @var bool
5757
*/
5858
private $processUncoveredFilesFromWhitelist = false;
5959

@@ -87,16 +87,16 @@ class PHP_CodeCoverage
8787
private $tests = array();
8888

8989
/**
90-
* @var boolean
90+
* @var bool
9191
*/
9292
private $pathCoverage = false;
9393

9494
/**
9595
* Constructor.
9696
*
97-
* @param PHP_CodeCoverage_Driver $driver
98-
* @param PHP_CodeCoverage_Filter $filter
99-
* @param bool $pathCoverage
97+
* @param PHP_CodeCoverage_Driver $driver
98+
* @param PHP_CodeCoverage_Filter $filter
99+
* @param bool $pathCoverage
100100
* @throws PHP_CodeCoverage_Exception
101101
*/
102102
public function __construct(PHP_CodeCoverage_Driver $driver = null, PHP_CodeCoverage_Filter $filter = null, $pathCoverage = true)
@@ -165,7 +165,7 @@ public function filter()
165165
* Returns the collected code coverage data.
166166
* Set $raw = true to bypass all filters.
167167
*
168-
* @param bool $raw
168+
* @param bool $raw
169169
* @return array
170170
* @since Method available since Release 1.1.0
171171
*/
@@ -221,7 +221,7 @@ public function setTests(array $tests)
221221
* Start collection of code coverage information.
222222
*
223223
* @param mixed $id
224-
* @param boolean $clear
224+
* @param bool $clear
225225
* @throws PHP_CodeCoverage_Exception
226226
*/
227227
public function start($id, $clear = false)
@@ -245,7 +245,7 @@ public function start($id, $clear = false)
245245
/**
246246
* Stop collection of code coverage information.
247247
*
248-
* @param boolean $append
248+
* @param bool $append
249249
* @param mixed $linesToBeCovered
250250
* @param array $linesToBeUsed
251251
* @return array
@@ -280,7 +280,7 @@ public function stop($append = true, $linesToBeCovered = array(), array $linesTo
280280
*
281281
* @param array $data
282282
* @param mixed $id
283-
* @param boolean $append
283+
* @param bool $append
284284
* @param mixed $linesToBeCovered
285285
* @param array $linesToBeUsed
286286
* @throws PHP_CodeCoverage_Exception
@@ -394,7 +394,7 @@ public function merge(PHP_CodeCoverage $that)
394394
}
395395

396396
/**
397-
* @param boolean $flag
397+
* @param bool $flag
398398
* @throws PHP_CodeCoverage_Exception
399399
* @since Method available since Release 1.1.0
400400
*/
@@ -419,7 +419,7 @@ public function getCacheTokens()
419419
}
420420

421421
/**
422-
* @param boolean $flag
422+
* @param bool $flag
423423
* @throws PHP_CodeCoverage_Exception
424424
* @since Method available since Release 2.0.0
425425
*/
@@ -436,7 +436,7 @@ public function setCheckForUnintentionallyCoveredCode($flag)
436436
}
437437

438438
/**
439-
* @param boolean $flag
439+
* @param bool $flag
440440
* @throws PHP_CodeCoverage_Exception
441441
*/
442442
public function setForceCoversAnnotation($flag)
@@ -452,7 +452,7 @@ public function setForceCoversAnnotation($flag)
452452
}
453453

454454
/**
455-
* @param boolean $flag
455+
* @param bool $flag
456456
* @throws PHP_CodeCoverage_Exception
457457
*/
458458
public function setMapTestClassNameToCoveredClassName($flag)
@@ -468,7 +468,7 @@ public function setMapTestClassNameToCoveredClassName($flag)
468468
}
469469

470470
/**
471-
* @param boolean $flag
471+
* @param bool $flag
472472
* @throws PHP_CodeCoverage_Exception
473473
*/
474474
public function setAddUncoveredFilesFromWhitelist($flag)
@@ -484,7 +484,7 @@ public function setAddUncoveredFilesFromWhitelist($flag)
484484
}
485485

486486
/**
487-
* @param boolean $flag
487+
* @param bool $flag
488488
* @throws PHP_CodeCoverage_Exception
489489
*/
490490
public function setProcessUncoveredFilesFromWhitelist($flag)
@@ -500,7 +500,7 @@ public function setProcessUncoveredFilesFromWhitelist($flag)
500500
}
501501

502502
/**
503-
* @param boolean $flag
503+
* @param bool $flag
504504
* @throws PHP_CodeCoverage_Exception
505505
*/
506506
public function setDisableIgnoredLines($flag)
@@ -755,7 +755,7 @@ private function getLinesToBeIgnored($filename)
755755

756756
if (!$ignore) {
757757
$start = $token->getLine();
758-
$end = $start + substr_count($token, "\n");
758+
$end = $start + substr_count($token, "\n");
759759

760760
// Do not ignore the first line when there is a token
761761
// before the comment

‎src/CodeCoverage/Driver/Xdebug.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
class PHP_CodeCoverage_Driver_Xdebug implements PHP_CodeCoverage_Driver
1818
{
1919
/**
20-
* @var integer
20+
* @var int
2121
*/
2222
private $flags;
2323

@@ -83,7 +83,7 @@ private function cleanup(array $data)
8383
unset($data[$file]['lines'][0]);
8484
}
8585

86-
if ($file != "xdebug://debug-eval" && file_exists($file)) {
86+
if ($file != 'xdebug://debug-eval' && file_exists($file)) {
8787
$numLines = $this->getNumberOfLinesInFile($file);
8888

8989
foreach (array_keys($data[$file]['lines']) as $line) {
@@ -99,7 +99,7 @@ private function cleanup(array $data)
9999

100100
/**
101101
* @param string $file
102-
* @return integer
102+
* @return int
103103
* @since Method available since Release 2.0.0
104104
*/
105105
private function getNumberOfLinesInFile($file)

‎src/CodeCoverage/Filter.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ public function isFile($filename)
197197
* When the whitelist is not empty, whitelisting is used.
198198
*
199199
* @param string $filename
200-
* @return boolean
200+
* @return bool
201201
* @throws PHP_CodeCoverage_Exception
202202
*/
203203
public function isFiltered($filename)
@@ -238,7 +238,7 @@ public function getWhitelist()
238238
/**
239239
* Returns whether this filter has a whitelist.
240240
*
241-
* @return boolean
241+
* @return bool
242242
* @since Method available since Release 1.1.0
243243
*/
244244
public function hasWhitelist()

‎src/CodeCoverage/Report/Clover.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class PHP_CodeCoverage_Report_Clover
2323
*/
2424
public function process(PHP_CodeCoverage $coverage, $target = null, $name = null)
2525
{
26-
$xmlDocument = new DOMDocument('1.0', 'UTF-8');
26+
$xmlDocument = new DOMDocument('1.0', 'UTF-8');
2727
$xmlDocument->formatOutput = true;
2828

2929
$xmlCoverage = $xmlDocument->createElement('coverage');

‎src/CodeCoverage/Report/Crap4j.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function __construct($threshold = 30)
4141
*/
4242
public function process(PHP_CodeCoverage $coverage, $target = null, $name = null)
4343
{
44-
$document = new DOMDocument('1.0', 'UTF-8');
44+
$document = new DOMDocument('1.0', 'UTF-8');
4545
$document->formatOutput = true;
4646

4747
$root = $document->createElement('crap_result');
@@ -136,9 +136,9 @@ public function process(PHP_CodeCoverage $coverage, $target = null, $name = null
136136
}
137137

138138
/**
139-
* @param float $crapValue
140-
* @param integer $cyclomaticComplexity
141-
* @param float $coveragePercent
139+
* @param float $crapValue
140+
* @param int $cyclomaticComplexity
141+
* @param float $coveragePercent
142142
* @return float
143143
*/
144144
private function getCrapLoad($crapValue, $cyclomaticComplexity, $coveragePercent)

‎src/CodeCoverage/Report/Factory.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
class PHP_CodeCoverage_Report_Factory
1717
{
1818
/**
19-
* @param PHP_CodeCoverage $coverage
19+
* @param PHP_CodeCoverage $coverage
2020
* @return PHP_CodeCoverage_Report_Node_Directory
2121
*/
2222
public function create(PHP_CodeCoverage $coverage)
@@ -42,7 +42,7 @@ public function create(PHP_CodeCoverage $coverage)
4242
* @param PHP_CodeCoverage_Report_Node_Directory $root
4343
* @param array $items
4444
* @param array $tests
45-
* @param boolean $cacheTokens
45+
* @param bool $cacheTokens
4646
*/
4747
private function addItems(PHP_CodeCoverage_Report_Node_Directory $root, array $items, array $tests, $cacheTokens)
4848
{
@@ -231,7 +231,7 @@ private function reducePaths(&$files)
231231
$max = count($original);
232232

233233
for ($i = 0; $i < $max; $i++) {
234-
$files[join('/', $paths[$i])] = $files[$original[$i]];
234+
$files[implode('/', $paths[$i])] = $files[$original[$i]];
235235
unset($files[$original[$i]]);
236236
}
237237

‎src/CodeCoverage/Report/HTML.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,21 @@ class PHP_CodeCoverage_Report_HTML
2626
private $generator;
2727

2828
/**
29-
* @var integer
29+
* @var int
3030
*/
3131
private $lowUpperBound;
3232

3333
/**
34-
* @var integer
34+
* @var int
3535
*/
3636
private $highLowerBound;
3737

3838
/**
3939
* Constructor.
4040
*
41-
* @param integer $lowUpperBound
42-
* @param integer $highLowerBound
43-
* @param string $generator
41+
* @param int $lowUpperBound
42+
* @param int $highLowerBound
43+
* @param string $generator
4444
*/
4545
public function __construct($lowUpperBound = 50, $highLowerBound = 90, $generator = '')
4646
{

‎src/CodeCoverage/Report/HTML/Renderer.php‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ abstract class PHP_CodeCoverage_Report_HTML_Renderer
3333
protected $date;
3434

3535
/**
36-
* @var integer
36+
* @var int
3737
*/
3838
protected $lowUpperBound;
3939

4040
/**
41-
* @var integer
41+
* @var int
4242
*/
4343
protected $highLowerBound;
4444

@@ -50,11 +50,11 @@ abstract class PHP_CodeCoverage_Report_HTML_Renderer
5050
/**
5151
* Constructor.
5252
*
53-
* @param string $templatePath
54-
* @param string $generator
55-
* @param string $date
56-
* @param integer $lowUpperBound
57-
* @param integer $highLowerBound
53+
* @param string $templatePath
54+
* @param string $generator
55+
* @param string $date
56+
* @param int $lowUpperBound
57+
* @param int $highLowerBound
5858
*/
5959
public function __construct($templatePath, $generator, $date, $lowUpperBound, $highLowerBound)
6060
{
@@ -123,21 +123,21 @@ protected function renderItemTemplate(Text_Template $template, array $data)
123123

124124
$template->setVar(
125125
array(
126-
'icon' => isset($data['icon']) ? $data['icon'] : '',
127-
'crap' => isset($data['crap']) ? $data['crap'] : '',
128-
'name' => $data['name'],
129-
'lines_bar' => $linesBar,
126+
'icon' => isset($data['icon']) ? $data['icon'] : '',
127+
'crap' => isset($data['crap']) ? $data['crap'] : '',
128+
'name' => $data['name'],
129+
'lines_bar' => $linesBar,
130130
'lines_executed_percent' => $data['linesExecutedPercentAsString'],
131-
'lines_level' => $linesLevel,
132-
'lines_number' => $linesNumber,
133-
'methods_bar' => $methodsBar,
131+
'lines_level' => $linesLevel,
132+
'lines_number' => $linesNumber,
133+
'methods_bar' => $methodsBar,
134134
'methods_tested_percent' => $data['testedMethodsPercentAsString'],
135-
'methods_level' => $methodsLevel,
136-
'methods_number' => $methodsNumber,
137-
'classes_bar' => $classesBar,
135+
'methods_level' => $methodsLevel,
136+
'methods_number' => $methodsNumber,
137+
'classes_bar' => $classesBar,
138138
'classes_tested_percent' => isset($data['testedClassesPercentAsString']) ? $data['testedClassesPercentAsString'] : '',
139-
'classes_level' => $classesLevel,
140-
'classes_number' => $classesNumber
139+
'classes_level' => $classesLevel,
140+
'classes_number' => $classesNumber
141141
)
142142
);
143143

@@ -245,13 +245,13 @@ protected function getCoverageBar($percent)
245245
'}}'
246246
);
247247

248-
$template->setVar(array('level' => $level, 'percent' => sprintf("%.2F", $percent)));
248+
$template->setVar(array('level' => $level, 'percent' => sprintf('%.2F', $percent)));
249249

250250
return $template->render();
251251
}
252252

253253
/**
254-
* @param integer $percent
254+
* @param int $percent
255255
* @return string
256256
*/
257257
protected function getColorLevel($percent)

‎src/CodeCoverage/Report/HTML/Renderer/Dashboard.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ protected function complexity(array $classes, $baseLink)
9292
}
9393

9494
return array(
95-
'class' => json_encode($result['class']),
95+
'class' => json_encode($result['class']),
9696
'method' => json_encode($result['method'])
9797
);
9898
}
@@ -161,7 +161,7 @@ protected function coverageDistribution(array $classes)
161161
}
162162

163163
return array(
164-
'class' => json_encode(array_values($result['class'])),
164+
'class' => json_encode(array_values($result['class'])),
165165
'method' => json_encode(array_values($result['method']))
166166
);
167167
}

0 commit comments

Comments
 (0)