Introduce invalidateResultCacheOnDiDefinitionChange config option

Author: Wirone

extension.neon

@@ -8,6 +8,7 @@ parameters:
 		containerXmlPath: null
 		constantHassers: true
 		consoleApplicationLoader: null
+		invalidateResultCacheOnDiDefinitionChange: true
 	stubFiles:
 		- stubs/Psr/Cache/CacheException.stub
 		- stubs/Psr/Cache/CacheItemInterface.stub
@@ -98,6 +99,7 @@ parametersSchema:
 		containerXmlPath: schema(string(), nullable())
 		constantHassers: bool()
 		consoleApplicationLoader: schema(string(), nullable())
+		?invalidateResultCacheOnDiDefinitionChange: bool()
 	])
 
 services:

src/Symfony/Configuration.php

@@ -31,4 +31,9 @@ public function getConsoleApplicationLoader(): ?string
 		return $this->parameters['consoleApplicationLoader'];
 	}
 
+	public function shouldInvalidateResultCacheOnDiDefinitionChange(): bool
+	{
+		return $this->parameters['invalidateResultCacheOnDiDefinitionChange'] ?? true;
+	}
+
 }

src/Symfony/SymfonyContainerResultCacheMetaExtension.php

@@ -15,10 +15,17 @@ final class SymfonyContainerResultCacheMetaExtension implements ResultCacheMetaE
 
 	private ServiceMap $serviceMap;
 
-	public function __construct(ParameterMap $parameterMap, ServiceMap $serviceMap)
+	private bool $invalidateResultCacheOnDiDefinitionChange;
+
+	public function __construct(
+		ParameterMap $parameterMap,
+		ServiceMap $serviceMap,
+		Configuration $configuration
+	)
 	{
 		$this->parameterMap = $parameterMap;
 		$this->serviceMap = $serviceMap;
+		$this->invalidateResultCacheOnDiDefinitionChange = $configuration->shouldInvalidateResultCacheOnDiDefinitionChange();
 	}
 
 	public function getKey(): string
@@ -28,6 +35,10 @@ public function getKey(): string
 
 	public function getHash(): string
 	{
+		if (!$this->invalidateResultCacheOnDiDefinitionChange) {
+			return 'disabled';
+		}
+
 		return hash('sha256', serialize([
 			'parameters' => array_map(
 				static fn (ParameterDefinition $parameter): array => [

tests/Symfony/SymfonyContainerResultCacheMetaExtensionTest.php

@@ -7,6 +7,7 @@
 use function file_put_contents;
 use function sys_get_temp_dir;
 use function tempnam;
+use function var_export;
 
 final class SymfonyContainerResultCacheMetaExtensionTest extends PHPStanTestCase
 {
@@ -27,6 +28,14 @@ public static function getAdditionalConfigFiles(): array
 		];
 	}
 
+	public function testInvalidatingResultCacheCanBeDisabled(): void
+	{
+		self::assertSame('disabled', $this->calculateSymfonyContainerHash(
+			'<container><services></services></container>',
+			false,
+		));
+	}
+
 	/**
 	 * @param list<string> $sameHashXmlContents
 	 *
@@ -361,24 +370,30 @@ public static function provideContainerHashIsCalculatedCorrectlyCases(): iterabl
 		];
 	}
 
-	private function calculateSymfonyContainerHash(string $xmlContent): string
+	private function calculateSymfonyContainerHash(
+		string $xmlContent,
+		bool $invalidateResultCacheOnDiDefinitionChange = true
+	): string
 	{
 		$symfonyContainerXmlPath = tempnam(sys_get_temp_dir(), 'phpstan-meta-extension-test-container-xml-');
 		self::$configFilePath = tempnam(sys_get_temp_dir(), 'phpstan-meta-extension-test-config-') . '.neon';
+		$invalidateResultCacheOnDiDefinitionChange = var_export($invalidateResultCacheOnDiDefinitionChange, true);
 
 		file_put_contents(
 			self::$configFilePath,
 			<<<NEON
 				parameters:
 					symfony:
 						containerXmlPath: '$symfonyContainerXmlPath'
+						invalidateResultCacheOnDiDefinitionChange: $invalidateResultCacheOnDiDefinitionChange
 				NEON,
 		);
 		file_put_contents($symfonyContainerXmlPath, $xmlContent);
 
 		$metaExtension = new SymfonyContainerResultCacheMetaExtension(
 			self::getContainer()->getByType(ParameterMap::class),
 			self::getContainer()->getByType(ServiceMap::class),
+			self::getContainer()->getByType(Configuration::class),
 		);
 
 		return $metaExtension->getHash();