postgres_fdw: Remove unnecessary variable.

robertmhaas · robertmhaas · commit 019e78813760 · 2016-02-10T08:17:43.000-05:00
It causes warnings in non-Assert-enabled builds.

Per report from Jeff Janes.
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c
@@ -2523,9 +2523,8 @@ fetch_more_data(ForeignScanState *node)
 
 		for (i = 0; i < numrows; i++)
 		{
-			ForeignScan *fsplan = (ForeignScan *) node->ss.ps.plan;
+			Assert(IsA(node->ss.ps.plan, ForeignScan));
 
-			Assert(IsA(fsplan, ForeignScan));
 			fsstate->tuples[i] =
 				make_tuple_from_result_row(res, i,
 										   fsstate->rel,

Original file line number	Diff line number	Diff line change
`@@ -2523,9 +2523,8 @@ fetch_more_data(ForeignScanState *node)`
`2523`	`2523`
`2524`	`2524`	`for (i = 0; i < numrows; i++)`
`2525`	`2525`	`{`
`2526`		`- ForeignScan fsplan = (ForeignScan ) node->ss.ps.plan;`
	`2526`	`+ Assert(IsA(node->ss.ps.plan, ForeignScan));`
`2527`	`2527`
`2528`		`- Assert(IsA(fsplan, ForeignScan));`
`2529`	`2528`	`fsstate->tuples[i] =`
`2530`	`2529`	`make_tuple_from_result_row(res, i,`
`2531`	`2530`	`fsstate->rel,`