Fix type in test_escape test

anarazel · anarazel · commit 05abb0f8303a · 2025-02-10T12:12:53.000-05:00
On machines where char is unsigned this could lead to option parsing looping endlessly. It's also too narrow a type on other hardware. Found via Tom Lane's monitoring of the buildfarm. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Security: CVE-2025-1094 Backpatch-through: 13
diff --git a/src/test/modules/test_escape/test_escape.c b/src/test/modules/test_escape/test_escape.c
@@ -740,7 +740,7 @@ int
 main(int argc, char *argv[])
 {
 	pe_test_config tc = {0};
-	char		c;
+	int			c;
 	int			option_index;
 
 	static const struct option long_options[] = {

Original file line number	Diff line number	Diff line change
`@@ -740,7 +740,7 @@ int`
`740`	`740`	`main(int argc, char *argv[])`
`741`	`741`	`{`
`742`	`742`	`pe_test_config tc = {0};`
`743`		`- char c;`
	`743`	`+ int c;`
`744`	`744`	`int option_index;`
`745`	`745`
`746`	`746`	`static const struct option long_options[] = {`