pg_dump: add missing "destroyPQExpBuffer(query)" in dumpForeignServer().

tglsfdc · tglsfdc · commit 074050f16a2d · 2016-04-11T00:00:08.000-04:00
Coverity complained about this resource leak (why now, I don't know,
since it's been like that a long time).  Our general policy in pg_dump
is that PQExpBuffers are worth cleaning up, so do it here too.  But
don't bother with a back-patch, because it seems unlikely that very
many databases contain enough FOREIGN SERVER objects to notice.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -14287,6 +14287,7 @@ dumpForeignServer(Archive *fout, ForeignServerInfo *srvinfo)
 	destroyPQExpBuffer(q);
 	destroyPQExpBuffer(delq);
 	destroyPQExpBuffer(labelq);
+	destroyPQExpBuffer(query);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -14287,6 +14287,7 @@ dumpForeignServer(Archive fout, ForeignServerInfo srvinfo)`
`14287`	`14287`	`destroyPQExpBuffer(q);`
`14288`	`14288`	`destroyPQExpBuffer(delq);`
`14289`	`14289`	`destroyPQExpBuffer(labelq);`
	`14290`	`+ destroyPQExpBuffer(query);`
`14290`	`14291`	`}`
`14291`	`14292`
`14292`	`14293`	`/*`