Fix typo in tts_virtual_copyslot.

tglsfdc · tglsfdc · commit 0a2f894c3c88 · 2019-09-22T14:21:07.000-04:00
The code used the destination slot's natts where it intended to use the source slot's natts. Adding an Assert shows that there is no case in "make check-world" where these counts are different, so maybe this is a harmless bug, but it's still a bug. Takayuki Tsunakawa Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1FD34C0E@G01JPEXMBYT05
diff --git a/src/backend/executor/execTuples.c b/src/backend/executor/execTuples.c
@@ -244,7 +244,7 @@ tts_virtual_materialize(TupleTableSlot *slot)
 static void
 tts_virtual_copyslot(TupleTableSlot *dstslot, TupleTableSlot *srcslot)
 {
-	TupleDesc	srcdesc = dstslot->tts_tupleDescriptor;
+	TupleDesc	srcdesc = srcslot->tts_tupleDescriptor;
 
 	Assert(srcdesc->natts <= dstslot->tts_tupleDescriptor->natts);
 

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ tts_virtual_materialize(TupleTableSlot *slot)`
`244`	`244`	`static void`
`245`	`245`	`tts_virtual_copyslot(TupleTableSlot dstslot, TupleTableSlot srcslot)`
`246`	`246`	`{`
`247`		`- TupleDesc srcdesc = dstslot->tts_tupleDescriptor;`
	`247`	`+ TupleDesc srcdesc = srcslot->tts_tupleDescriptor;`
`248`	`248`
`249`	`249`	`Assert(srcdesc->natts <= dstslot->tts_tupleDescriptor->natts);`
`250`	`250`