If RelationBuildDesc() fails to open a critical system index, PANIC with

tglsfdc · tglsfdc · commit 1743778d04cf · 2008-02-27T17:44:19.000Z
a relevant error message instead of just dumping core.  Odd that nobody
reported this before Darren Reed.
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.266 2008/01/01 19:45:53 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.267 2008/02/27 17:44:19 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2550,7 +2550,10 @@ RelationCacheInitializePhase2(void)
 
 #define LOAD_CRIT_INDEX(indexoid) \
 		do { \
-			ird = RelationBuildDesc((indexoid), NULL); \
+			ird = RelationBuildDesc(indexoid, NULL); \
+			if (ird == NULL) \
+				elog(PANIC, "could not open critical system index %u", \
+					 indexoid); \
 			ird->rd_isnailed = true; \
 			ird->rd_refcnt = 1; \
 		} while (0)

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.266 2008/01/01 19:45:53 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.267 2008/02/27 17:44:19 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -2550,7 +2550,10 @@ RelationCacheInitializePhase2(void)`
`2550`	`2550`
`2551`	`2551`	`#define LOAD_CRIT_INDEX(indexoid) \`
`2552`	`2552`	`do { \`
`2553`		`- ird = RelationBuildDesc((indexoid), NULL); \`
	`2553`	`+ ird = RelationBuildDesc(indexoid, NULL); \`
	`2554`	`+ if (ird == NULL) \`
	`2555`	`+ elog(PANIC, "could not open critical system index %u", \`
	`2556`	`+ indexoid); \`
`2554`	`2557`	`ird->rd_isnailed = true; \`
`2555`	`2558`	`ird->rd_refcnt = 1; \`
`2556`	`2559`	`} while (0)`