Maintain local LogwrtResult consistently

simonat2ndQuadrant · simonat2ndQuadrant · commit 1e29e6324ca7 · 2016-01-12T07:33:20.000Z
Teach GetFlushRecPtr() to update LogwrtResult cache as performed by all other
functions in xlog.c
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -7862,13 +7862,11 @@ GetInsertRecPtr(void)
 XLogRecPtr
 GetFlushRecPtr(void)
 {
-	XLogRecPtr	recptr;
-
 	SpinLockAcquire(&XLogCtl->info_lck);
-	recptr = XLogCtl->LogwrtResult.Flush;
+	LogwrtResult = XLogCtl->LogwrtResult;
 	SpinLockRelease(&XLogCtl->info_lck);
 
-	return recptr;
+	return LogwrtResult.Flush;
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -7862,13 +7862,11 @@ GetInsertRecPtr(void)`
`7862`	`7862`	`XLogRecPtr`
`7863`	`7863`	`GetFlushRecPtr(void)`
`7864`	`7864`	`{`
`7865`		`- XLogRecPtr recptr;`
`7866`		`-`
`7867`	`7865`	`SpinLockAcquire(&XLogCtl->info_lck);`
`7868`		`- recptr = XLogCtl->LogwrtResult.Flush;`
	`7866`	`+ LogwrtResult = XLogCtl->LogwrtResult;`
`7869`	`7867`	`SpinLockRelease(&XLogCtl->info_lck);`
`7870`	`7868`
`7871`		`- return recptr;`
	`7869`	`+ return LogwrtResult.Flush;`
`7872`	`7870`	`}`
`7873`	`7871`
`7874`	`7872`	`/*`