Fix assorted inconsistent function declarations.

tglsfdc · tglsfdc · commit 248c096b265d · 2015-04-07T16:56:21.000-04:00
While gcc doesn't complain if you declare a function "static" and then
define it not-static, other compilers do; and in any case the code is
highly misleading this way.  Add the missing "static" keywords to a
couple of recent patches.  Per buildfarm member pademelon.
diff --git a/contrib/pg_upgrade/pg_upgrade.c b/contrib/pg_upgrade/pg_upgrade.c
@@ -223,7 +223,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, const char
 }
 #endif
 
-void
+static void
 get_restricted_token(const char *progname)
 {
 #ifdef WIN32
diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -1151,7 +1151,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, const char
 }
 #endif
 
-void
+static void
 get_restricted_token(const char *progname)
 {
 #ifdef WIN32

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`223`	`223`	`}`
`224`	`224`	`#endif`
`225`	`225`
`226`		`-void`
	`226`	`+static void`
`227`	`227`	`get_restricted_token(const char *progname)`
`228`	`228`	`{`
`229`	`229`	`#ifdef WIN32`
Original file line number	Diff line number	Diff line change
`@@ -1151,7 +1151,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`1151`	`1151`	`}`
`1152`	`1152`	`#endif`
`1153`	`1153`
`1154`		`-void`
	`1154`	`+static void`
`1155`	`1155`	`get_restricted_token(const char *progname)`
`1156`	`1156`	`{`
`1157`	`1157`	`#ifdef WIN32`