pg_upgrade: Improve style of a few verbose messages

michaelpq · michaelpq · commit 249d74394500 · 2023-08-18T09:40:46.000+09:00
Author: Peter Smith Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/CAHut+PuOB4bUwkYAjA_NkTrYaocKy6W3ZYK5Pin305R7mNSLgA@mail.gmail.com
diff --git a/src/bin/pg_upgrade/info.c b/src/bin/pg_upgrade/info.c
@@ -642,7 +642,7 @@ print_db_infos(DbInfoArr *db_arr)
 
 	for (dbnum = 0; dbnum < db_arr->ndbs; dbnum++)
 	{
-		pg_log(PG_VERBOSE, "Database: %s", db_arr->dbs[dbnum].db_name);
+		pg_log(PG_VERBOSE, "Database: \"%s\"", db_arr->dbs[dbnum].db_name);
 		print_rel_infos(&db_arr->dbs[dbnum].rel_arr);
 	}
 }
@@ -654,7 +654,7 @@ print_rel_infos(RelInfoArr *rel_arr)
 	int			relnum;
 
 	for (relnum = 0; relnum < rel_arr->nrels; relnum++)
-		pg_log(PG_VERBOSE, "relname: %s.%s: reloid: %u reltblspace: %s",
+		pg_log(PG_VERBOSE, "relname: \"%s.%s\", reloid: %u, reltblspace: \"%s\"",
 			   rel_arr->rels[relnum].nspname,
 			   rel_arr->rels[relnum].relname,
 			   rel_arr->rels[relnum].reloid,

Original file line number	Diff line number	Diff line change
`@@ -642,7 +642,7 @@ print_db_infos(DbInfoArr *db_arr)`
`642`	`642`
`643`	`643`	`for (dbnum = 0; dbnum < db_arr->ndbs; dbnum++)`
`644`	`644`	`{`
`645`		`- pg_log(PG_VERBOSE, "Database: %s", db_arr->dbs[dbnum].db_name);`
	`645`	`+ pg_log(PG_VERBOSE, "Database: \"%s\"", db_arr->dbs[dbnum].db_name);`
`646`	`646`	`print_rel_infos(&db_arr->dbs[dbnum].rel_arr);`
`647`	`647`	`}`
`648`	`648`	`}`
`@@ -654,7 +654,7 @@ print_rel_infos(RelInfoArr *rel_arr)`
`654`	`654`	`int relnum;`
`655`	`655`
`656`	`656`	`for (relnum = 0; relnum < rel_arr->nrels; relnum++)`
`657`		`- pg_log(PG_VERBOSE, "relname: %s.%s: reloid: %u reltblspace: %s",`
	`657`	`+ pg_log(PG_VERBOSE, "relname: \"%s.%s\", reloid: %u, reltblspace: \"%s\"",`
`658`	`658`	`rel_arr->rels[relnum].nspname,`
`659`	`659`	`rel_arr->rels[relnum].relname,`
`660`	`660`	`rel_arr->rels[relnum].reloid,`