libpq: Error message improvement

alvherre · alvherre · commit 27debd05dcbd · 2023-05-16T11:50:08.000+02:00
Move a variable name out of the translatable message, to make it
identical to others.
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -1481,8 +1481,8 @@ connectOptions2(PGconn *conn)
 		&& strcmp(conn->sslrootcert, "system") == 0)
 	{
 		conn->status = CONNECTION_BAD;
-		libpq_append_conn_error(conn, "sslrootcert value \"%s\" invalid when SSL support is not compiled in",
-								conn->sslrootcert);
+		libpq_append_conn_error(conn, "%s value \"%s\" invalid when SSL support is not compiled in",
+								"sslrootcert", conn->sslrootcert);
 		return false;
 	}
 #endif

Original file line number	Diff line number	Diff line change
`@@ -1481,8 +1481,8 @@ connectOptions2(PGconn *conn)`
`1481`	`1481`	`&& strcmp(conn->sslrootcert, "system") == 0)`
`1482`	`1482`	`{`
`1483`	`1483`	`conn->status = CONNECTION_BAD;`
`1484`		`- libpq_append_conn_error(conn, "sslrootcert value \"%s\" invalid when SSL support is not compiled in",`
`1485`		`- conn->sslrootcert);`
	`1484`	`+ libpq_append_conn_error(conn, "%s value \"%s\" invalid when SSL support is not compiled in",`
	`1485`	`+ "sslrootcert", conn->sslrootcert);`
`1486`	`1486`	`return false;`
`1487`	`1487`	`}`
`1488`	`1488`	`#endif`