Remove extra whitespace in pg_upgrade status message.

nathan-bossart · nathan-bossart · commit 2ceeb638b7b2 · 2024-09-25T11:18:56.000-05:00
There's no need to add another level of indentation to this status message. pg_log() will put it in the right place. Oversight in commit 347758b. Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/ZunW7XHLd2uTts4f%40nathan Backpatch-through: 17
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
@@ -419,7 +419,7 @@ process_data_type_check(DbInfo *dbinfo, PGresult *res, void *arg)
 		 */
 		if (!(*state->result))
 		{
-			pg_log(PG_REPORT, "    failed check: %s", _(state->check->status));
+			pg_log(PG_REPORT, "failed check: %s", _(state->check->status));
 			appendPQExpBuffer(*state->report, "\n%s\n%s    %s\n",
 							  _(state->check->report_text),
 							  _("A list of the problem columns is in the file:"),

Original file line number	Diff line number	Diff line change
`@@ -419,7 +419,7 @@ process_data_type_check(DbInfo dbinfo, PGresult res, void *arg)`
`419`	`419`	`*/`
`420`	`420`	`if (!(*state->result))`
`421`	`421`	`{`
`422`		`- pg_log(PG_REPORT, " failed check: %s", _(state->check->status));`
	`422`	`+ pg_log(PG_REPORT, "failed check: %s", _(state->check->status));`
`423`	`423`	`appendPQExpBuffer(*state->report, "\n%s\n%s %s\n",`
`424`	`424`	`_(state->check->report_text),`
`425`	`425`	`_("A list of the problem columns is in the file:"),`