Add missing "return" statement to accumulate_append_subpath.

robertmhaas · robertmhaas · commit 2fd58096f027 · 2018-01-10T11:21:20.000-05:00
Without this, Parallel Append can end up with extra children. Report by Rajkumar Raghuwanshi. Fix by Amit Khandekar. Brown paper bag bug by me. Discussion: http://postgr.es/m/CAKcux6mBF-NiddyEe9LwymoUC5+wh8bQJ=uk2gGkOE+L8cv=LA@mail.gmail.com
diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c
@@ -1926,6 +1926,7 @@ accumulate_append_subpath(Path *path, List **subpaths, List **special_subpaths)
 							  apath->first_partial_path);
 			*special_subpaths = list_concat(*special_subpaths,
 											new_special_subpaths);
+			return;
 		}
 	}
 	else if (IsA(path, MergeAppendPath))

Original file line number	Diff line number	Diff line change
`@@ -1926,6 +1926,7 @@ accumulate_append_subpath(Path path, List subpaths, List *special_subpaths)`
`1926`	`1926`	`apath->first_partial_path);`
`1927`	`1927`	`special_subpaths = list_concat(special_subpaths,`
`1928`	`1928`	`new_special_subpaths);`
	`1929`	`+ return;`
`1929`	`1930`	`}`
`1930`	`1931`	`}`
`1931`	`1932`	`else if (IsA(path, MergeAppendPath))`