Comment said we don't free the lockarray, and why. The proper fix is to

mhagander · mhagander · commit 30c52532d2fe · 2008-12-04T14:07:42.000Z
make the code do what the comment says...
diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.112 2008/12/04 02:52:31 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.113 2008/12/04 14:07:42 mha Exp $
  *
  * NOTES
  *
@@ -918,8 +918,6 @@ destroy_ssl_system(void)
 			 * This means we leak a little memory on repeated load/unload
 			 * of the library.
 			 */
-			free(pq_lockarray);
-			pq_lockarray = NULL;
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.112 2008/12/04 02:52:31 momjian Exp $`
	`14`	`+ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.113 2008/12/04 14:07:42 mha Exp $`
`15`	`15`	`*`
`16`	`16`	`* NOTES`
`17`	`17`	`*`
`@@ -918,8 +918,6 @@ destroy_ssl_system(void)`
`918`	`918`	`* This means we leak a little memory on repeated load/unload`
`919`	`919`	`* of the library.`
`920`	`920`	`*/`
`921`		`- free(pq_lockarray);`
`922`		`- pq_lockarray = NULL;`
`923`	`921`	`}`
`924`	`922`	`}`
`925`	`923`