Fix C error reported by Oracle compiler.

macdice · macdice · commit 45aef9f6bb0f · 2025-01-08T17:02:30.000+13:00
Commit 66aaabe (branches 13 - 17 only) was not acceptable to the Oracle Developer Studio compiler on build farm animal wrasse. It accidentally used a C++ style return statement to wrap a void function. None of the usual compilers complained, but it is right, that is not allowed in C. Fix. Reported-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/Z33vgfVgvOnbFLN9%40paquier.xyz
diff --git a/src/backend/storage/smgr/smgr.c b/src/backend/storage/smgr/smgr.c
@@ -706,7 +706,7 @@ smgrtruncate(SMgrRelation reln, ForkNumber *forknum, int nforks,
 	for (int i = 0; i < nforks; ++i)
 		old_nblocks[i] = smgrnblocks(reln, forknum[i]);
 
-	return smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);
+	smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -706,7 +706,7 @@ smgrtruncate(SMgrRelation reln, ForkNumber *forknum, int nforks,`
`706`	`706`	`for (int i = 0; i < nforks; ++i)`
`707`	`707`	`old_nblocks[i] = smgrnblocks(reln, forknum[i]);`
`708`	`708`
`709`		`- return smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);`
	`709`	`+ smgrtruncate2(reln, forknum, nforks, old_nblocks, nblocks);`
`710`	`710`	`}`
`711`	`711`
`712`	`712`	`/*`