Fix last remaining uninitialized memory warnings

petere · petere · commit 4a8fef0d7339 · 2023-08-09T10:00:50.000+02:00
gcc (version 13) fails to properly analyze the code due to the loop stop condition including `l != NULL`. Let's just help it out. Author: Tristan Partin <tristan@neon.tech> Discussion: https://www.postgresql.org/message-id/flat/CT6HJ3U8068R.3A8SJMV02D9BC@gonk
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -2239,7 +2239,7 @@ evalStandardFunc(CState *st,
 {
 	/* evaluate all function arguments */
 	int			nargs = 0;
-	PgBenchValue vargs[MAX_FARGS];
+	PgBenchValue vargs[MAX_FARGS] = { 0 };
 	PgBenchExprLink *l = args;
 	bool		has_null = false;
 
diff --git a/src/bin/pgbench/pgbench.h b/src/bin/pgbench/pgbench.h
@@ -33,7 +33,7 @@ union YYSTYPE;
  */
 typedef enum
 {
-	PGBT_NO_VALUE,
+	PGBT_NO_VALUE = 0,
 	PGBT_NULL,
 	PGBT_INT,
 	PGBT_DOUBLE,

Original file line number	Diff line number	Diff line change
`@@ -2239,7 +2239,7 @@ evalStandardFunc(CState *st,`
`2239`	`2239`	`{`
`2240`	`2240`	`/* evaluate all function arguments */`
`2241`	`2241`	`int nargs = 0;`
`2242`		`- PgBenchValue vargs[MAX_FARGS];`
	`2242`	`+ PgBenchValue vargs[MAX_FARGS] = { 0 };`
`2243`	`2243`	`PgBenchExprLink *l = args;`
`2244`	`2244`	`bool has_null = false;`
`2245`	`2245`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ union YYSTYPE;`
`33`	`33`	`*/`
`34`	`34`	`typedef enum`
`35`	`35`	`{`
`36`		`- PGBT_NO_VALUE,`
	`36`	`+ PGBT_NO_VALUE = 0,`
`37`	`37`	`PGBT_NULL,`
`38`	`38`	`PGBT_INT,`
`39`	`39`	`PGBT_DOUBLE,`