Remove duplicate variable declaration in fe-connect.c

michaelpq · michaelpq · commit 554ca6954ecb · 2019-02-22T13:16:47.000+09:00
The same variables are declared twice when checking if a connection is writable, which is useless. Author: Haribabu Kommi Discussion: https://postgr.es/m/CAJrrPGf=rcALB54w_Tg1_hx3y+cgSWaERY-uYSQzGc3Zt5XN4g@mail.gmail.com
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -3349,9 +3349,6 @@ PQconnectPoll(PGconn *conn)
 					if (strncmp(val, "on", 2) == 0)
 					{
 						/* Not writable; fail this connection. */
-						const char *displayed_host;
-						const char *displayed_port;
-
 						PQclear(res);
 						restoreErrorMessage(conn, &savedMessage);
 

Original file line number	Diff line number	Diff line change
`@@ -3349,9 +3349,6 @@ PQconnectPoll(PGconn *conn)`
`3349`	`3349`	`if (strncmp(val, "on", 2) == 0)`
`3350`	`3350`	`{`
`3351`	`3351`	`/* Not writable; fail this connection. */`
`3352`		`- const char *displayed_host;`
`3353`		`- const char *displayed_port;`
`3354`		`-`
`3355`	`3352`	`PQclear(res);`
`3356`	`3353`	`restoreErrorMessage(conn, &savedMessage);`
`3357`	`3354`