Oops, fix recoveryStopsBefore functions for regular commits.

hlinnaka · hlinnaka · commit 60d931827b0c · 2014-07-29T17:19:43.000+03:00
Pointed out by Tom Lane. Backpatch to 9.4, the code was structured
differently in earlier branches and didn't have this mistake.
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -5515,7 +5515,7 @@ recoveryStopsBefore(XLogRecord *record)
 		isCommit = true;
 		recordXid = record->xl_xid;
 	}
-	if (record_info == XLOG_XACT_COMMIT_PREPARED)
+	else if (record_info == XLOG_XACT_COMMIT_PREPARED)
 	{
 		isCommit = true;
 		recordXid = ((xl_xact_commit_prepared *) XLogRecGetData(record))->xid;

Original file line number	Diff line number	Diff line change
`@@ -5515,7 +5515,7 @@ recoveryStopsBefore(XLogRecord *record)`
`5515`	`5515`	`isCommit = true;`
`5516`	`5516`	`recordXid = record->xl_xid;`
`5517`	`5517`	`}`
`5518`		`- if (record_info == XLOG_XACT_COMMIT_PREPARED)`
	`5518`	`+ else if (record_info == XLOG_XACT_COMMIT_PREPARED)`
`5519`	`5519`	`{`
`5520`	`5520`	`isCommit = true;`
`5521`	`5521`	`recordXid = ((xl_xact_commit_prepared *) XLogRecGetData(record))->xid;`