Fix misuse of PqMsg_Close.

nathan-bossart · nathan-bossart · commit 6475e663b3c6 · 2023-08-29T18:32:38.000-07:00
EndCommand() and EndReplicationCommand() should use PqMsg_CommandComplete instead. Oversight in commit f4b54e1. Reported-by: Pavel Stehule, Tatsuo Ishii Author: Pavel Stehule Reviewed-by: Aleksander Alekseev, Michael Paquier Discussion: https://postgr.es/m/CAFj8pRAMDCJXjnwiCkCB1yO1f7NPggFY8PwwAJDnugu-Z2G-Cg%40mail.gmail.com
diff --git a/src/backend/tcop/dest.c b/src/backend/tcop/dest.c
@@ -176,7 +176,7 @@ EndCommand(const QueryCompletion *qc, CommandDest dest, bool force_undecorated_o
 
 			len = BuildQueryCompletionString(completionTag, qc,
 											 force_undecorated_output);
-			pq_putmessage(PqMsg_Close, completionTag, len + 1);
+			pq_putmessage(PqMsg_CommandComplete, completionTag, len + 1);
 
 		case DestNone:
 		case DestDebug:
@@ -200,7 +200,7 @@ EndCommand(const QueryCompletion *qc, CommandDest dest, bool force_undecorated_o
 void
 EndReplicationCommand(const char *commandTag)
 {
-	pq_putmessage(PqMsg_Close, commandTag, strlen(commandTag) + 1);
+	pq_putmessage(PqMsg_CommandComplete, commandTag, strlen(commandTag) + 1);
 }
 
 /* ----------------

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ EndCommand(const QueryCompletion *qc, CommandDest dest, bool force_undecorated_o`
`176`	`176`
`177`	`177`	`len = BuildQueryCompletionString(completionTag, qc,`
`178`	`178`	`force_undecorated_output);`
`179`		`- pq_putmessage(PqMsg_Close, completionTag, len + 1);`
	`179`	`+ pq_putmessage(PqMsg_CommandComplete, completionTag, len + 1);`
`180`	`180`
`181`	`181`	`case DestNone:`
`182`	`182`	`case DestDebug:`
`@@ -200,7 +200,7 @@ EndCommand(const QueryCompletion *qc, CommandDest dest, bool force_undecorated_o`
`200`	`200`	`void`
`201`	`201`	`EndReplicationCommand(const char *commandTag)`
`202`	`202`	`{`
`203`		`- pq_putmessage(PqMsg_Close, commandTag, strlen(commandTag) + 1);`
	`203`	`+ pq_putmessage(PqMsg_CommandComplete, commandTag, strlen(commandTag) + 1);`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`/* ----------------`