Fix assorted inconsistent function declarations.

tglsfdc · tglsfdc · commit 6a560f5b5ff8 · 2015-04-07T16:56:21.000-04:00
While gcc doesn't complain if you declare a function "static" and then
define it not-static, other compilers do; and in any case the code is
highly misleading this way.  Add the missing "static" keywords to a
couple of recent patches.  Per buildfarm member pademelon.
diff --git a/contrib/pg_upgrade/pg_upgrade.c b/contrib/pg_upgrade/pg_upgrade.c
@@ -289,7 +289,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, const char
 }
 #endif
 
-void
+static void
 get_restricted_token(const char *progname)
 {
 #ifdef WIN32
diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -1155,7 +1155,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, const char
 }
 #endif
 
-void
+static void
 get_restricted_token(const char *progname)
 {
 #ifdef WIN32

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`289`	`289`	`}`
`290`	`290`	`#endif`
`291`	`291`
`292`		`-void`
	`292`	`+static void`
`293`	`293`	`get_restricted_token(const char *progname)`
`294`	`294`	`{`
`295`	`295`	`#ifdef WIN32`
Original file line number	Diff line number	Diff line change
`@@ -1155,7 +1155,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`1155`	`1155`	`}`
`1156`	`1156`	`#endif`
`1157`	`1157`
`1158`		`-void`
	`1158`	`+static void`
`1159`	`1159`	`get_restricted_token(const char *progname)`
`1160`	`1160`	`{`
`1161`	`1161`	`#ifdef WIN32`