Improve comment of pgstat_read_statsfile()

michaelpq · michaelpq · commit 72c0b24b2ddd · 2024-07-12T09:31:33.000+09:00
The comment at the top of pgstat_read_statsfile() mentioned that the stats are read from the on-disk file into the pgstats dshash. This is incorrect for fix-numbered stats as these are loaded directly into shared memory. This commit simplifies the comment to be more general. Author: Bertrand Drouvot Discussion: https://postgr.es/m/Zo/eJIHUcqKxeSgv@ip-10-97-1-34.eu-west-3.compute.internal
diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c
@@ -1495,7 +1495,7 @@ read_chunk(FILE *fpin, void *ptr, size_t len)
 #define read_chunk_s(fpin, ptr) read_chunk(fpin, ptr, sizeof(*ptr))
 
 /*
- * Reads in existing statistics file into the shared stats hash.
+ * Reads in existing statistics file into memory.
  *
  * This function is called in the only process that is accessing the shared
  * stats so locking is not required.

Original file line number	Diff line number	Diff line change
`@@ -1495,7 +1495,7 @@ read_chunk(FILE fpin, void ptr, size_t len)`
`1495`	`1495`	`#define read_chunk_s(fpin, ptr) read_chunk(fpin, ptr, sizeof(*ptr))`
`1496`	`1496`
`1497`	`1497`	`/*`
`1498`		`- * Reads in existing statistics file into the shared stats hash.`
	`1498`	`+ * Reads in existing statistics file into memory.`
`1499`	`1499`	`*`
`1500`	`1500`	`* This function is called in the only process that is accessing the shared`
`1501`	`1501`	`* stats so locking is not required.`