Fix some spurious new compiler warnings in MSVC.

anarazel · anarazel · commit 73616126b4dc · 2018-11-17T11:41:14.000-08:00
Per buildfarm animal bowerbird. Discussion: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-11-17%2002%3A30%3A20
diff --git a/src/backend/executor/execTuples.c b/src/backend/executor/execTuples.c
@@ -132,6 +132,8 @@ static Datum
 tts_virtual_getsysattr(TupleTableSlot *slot, int attnum, bool *isnull)
 {
 	elog(ERROR, "virtual tuple table slot does not have system atttributes");
+
+	return 0; /* silence compiler warnings */
 }
 
 /*
@@ -488,6 +490,8 @@ static Datum
 tts_minimal_getsysattr(TupleTableSlot *slot, int attnum, bool *isnull)
 {
 	elog(ERROR, "minimal tuple table slot does not have system atttributes");
+
+	return 0; /* silence compiler warnings */
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,8 @@ static Datum`
`132`	`132`	`tts_virtual_getsysattr(TupleTableSlot slot, int attnum, bool isnull)`
`133`	`133`	`{`
`134`	`134`	`elog(ERROR, "virtual tuple table slot does not have system atttributes");`
	`135`	`+`
	`136`	`+ return 0; /* silence compiler warnings */`
`135`	`137`	`}`
`136`	`138`
`137`	`139`	`/*`
`@@ -488,6 +490,8 @@ static Datum`
`488`	`490`	`tts_minimal_getsysattr(TupleTableSlot slot, int attnum, bool isnull)`
`489`	`491`	`{`
`490`	`492`	`elog(ERROR, "minimal tuple table slot does not have system atttributes");`
	`493`	`+`
	`494`	`+ return 0; /* silence compiler warnings */`
`491`	`495`	`}`
`492`	`496`
`493`	`497`	`static void`