Improve gendef.pl diagnostic on failure to open sym file

adunstan · adunstan · commit 74d2c0dbfd94 · 2017-10-26T10:01:02.000-04:00
There have been numerous buildfarm failures but the diagnostic is
currently silent about the reason for failure to open the file. Let's
see if we can get to the bottom of it.

Backpatch to all live branches.
diff --git a/src/tools/msvc/gendef.pl b/src/tools/msvc/gendef.pl
@@ -32,7 +32,7 @@ sub dumpsyms
 sub extract_syms
 {
 	my ($symfile, $def) = @_;
-	open(my $f, '<', $symfile) || die "Could not open $symfile for $_\n";
+	open(my $f, '<', $symfile) || die "Could not open $symfile for $_: $!\n";
 	while (<$f>)
 	{
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ sub dumpsyms`
`32`	`32`	`sub extract_syms`
`33`	`33`	`{`
`34`	`34`	`my ($symfile, $def) = @_;`
`35`		`- open(my $f, '<', $symfile) \|\| die "Could not open $symfile for $_\n";`
	`35`	`+ open(my $f, '<', $symfile) \|\| die "Could not open $symfile for $_: $!\n";`
`36`	`36`	`while (<$f>)`
`37`	`37`	`{`
`38`	`38`