Add the possibility to specify an explicit validator function for foreign-data

wrappers (similar to procedural languages).  This way we don't need to retain
the nearly empty libraries, and we are more free in how to implement the
wrapper API in the future.

Author: petere

doc/src/sgml/catalogs.sgml

@@ -1,4 +1,4 @@
-<!-- $PostgreSQL: pgsql/doc/src/sgml/catalogs.sgml,v 2.197 2009/02/09 20:57:59 alvherre Exp $ -->
+<!-- $PostgreSQL: pgsql/doc/src/sgml/catalogs.sgml,v 2.198 2009/02/24 10:06:31 petere Exp $ -->
 <!--
  Documentation of the system catalogs, directed toward PostgreSQL developers
  -->
@@ -2466,10 +2466,16 @@
      </row>
 
      <row>
-      <entry><structfield>fdwlibrary</structfield></entry>
-      <entry><type>text</type></entry>
-      <entry></entry>
-      <entry>File name of the library implementing this foreign-data wrapper</entry>
+      <entry><structfield>fdwvalidator</structfield></entry>
+      <entry><type>oid</type></entry>
+      <entry><literal><link linkend="catalog-pg-proc"><structname>pg_proc</structname></link>.oid</literal></entry>
+      <entry>
+       References a validator function that is responsible for
+       checking the validity of the generic options given to the
+       foreign-data wrapper, as well as to foreign servers and user
+       mappings using the foreign-data wrapper.  Zero if no validator
+       is provided.
+      </entry>
      </row>
 
      <row>

doc/src/sgml/keywords.sgml

@@ -1,4 +1,4 @@
-<!-- $PostgreSQL: pgsql/doc/src/sgml/keywords.sgml,v 2.22 2008/12/19 16:25:16 petere Exp $ -->
+<!-- $PostgreSQL: pgsql/doc/src/sgml/keywords.sgml,v 2.23 2009/02/24 10:06:31 petere Exp $ -->
 
 <appendix id="sql-keywords-appendix">
  <title><acronym>SQL</acronym> Key Words</title>
@@ -2687,14 +2687,6 @@
     <entry>reserved</entry>
     <entry>reserved</entry>
    </row>
-   <row>
-    <entry><token>LIBRARY</token></entry>
-    <entry>non-reserved</entry>
-    <entry>non-reserved</entry>
-    <entry>non-reserved</entry>
-    <entry></entry>
-    <entry></entry>
-   </row>
    <row>
     <entry><token>LIKE</token></entry>
     <entry>reserved (can be function or type)</entry>

doc/src/sgml/ref/alter_foreign_data_wrapper.sgml

@@ -1,5 +1,5 @@
 <!--
-$PostgreSQL: pgsql/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml,v 1.1 2008/12/19 16:25:16 petere Exp $
+$PostgreSQL: pgsql/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml,v 1.2 2009/02/24 10:06:32 petere Exp $
 PostgreSQL documentation
 -->
 
@@ -21,7 +21,7 @@ PostgreSQL documentation
  <refsynopsisdiv>
 <synopsis>
 ALTER FOREIGN DATA WRAPPER <replaceable class="parameter">name</replaceable>
-    [ LIBRARY '<replaceable class="parameter">libraryname</replaceable>' ]
+    [ VALIDATOR <replaceable class="parameter">valfunction</replaceable> | NO VALIDATOR ]
     [ OPTIONS ( [ ADD | SET | DROP ] <replaceable class="PARAMETER">option</replaceable> ['<replaceable class="PARAMETER">value</replaceable>'] [, ... ]) ]
 ALTER FOREIGN DATA WRAPPER <replaceable class="parameter">name</replaceable> OWNER TO <replaceable>new_owner</replaceable>
 </synopsis>
@@ -58,14 +58,14 @@ ALTER FOREIGN DATA WRAPPER <replaceable class="parameter">name</replaceable> OWN
    </varlistentry>
 
    <varlistentry>
-    <term><replaceable class="parameter">libraryname</replaceable></term>
+    <term><literal>VALIDATOR <replaceable class="parameter">valfunction</replaceable></literal></term>
     <listitem>
      <para>
-      New name of the foreign-data wrapper library.
+      Specifies a new foreign-data wrapper validator function.
      </para>
 
      <para>
-      Note that it is possible that after changing the library, the
+      Note that it is possible that after changing the validator the
       options to the foreign-data wrapper, servers, and user mappings
       have become invalid.   It is up to the user to make sure that
       these options are correct before using the foreign-data
@@ -74,6 +74,16 @@ ALTER FOREIGN DATA WRAPPER <replaceable class="parameter">name</replaceable> OWN
     </listitem>
    </varlistentry>
 
+   <varlistentry>
+    <term><literal>NO VALIDATOR</literal></term>
+    <listitem>
+     <para>
+      This is used to specify that the foreign-data wrapper should no
+      longer have a validator function.
+     </para>
+    </listitem>
+   </varlistentry>
+
    <varlistentry>
     <term><literal>OPTIONS ( [ ADD | SET | DROP ] <replaceable class="PARAMETER">option</replaceable> ['<replaceable class="PARAMETER">value</replaceable>'] [, ... ] )</literal></term>
     <listitem>
@@ -102,10 +112,10 @@ ALTER FOREIGN DATA WRAPPER dbi OPTIONS (ADD foo '1', DROP 'bar');
   </para>
 
   <para>
-   Change the foreign-data wrapper <literal>dbi</> library
-   to <literal>/home/bob/mylibrary.so</>:
+   Change the foreign-data wrapper <literal>dbi</> validator
+   to <literal>bob.myvalidator</>:
 <programlisting>
-ALTER FOREIGN DATA WRAPPER dbi LIBRARY '/home/bob/mylibrary.so';
+ALTER FOREIGN DATA WRAPPER dbi VALIDATOR bob.myvalidator;
 </programlisting>
   </para>
  </refsect1>
@@ -115,8 +125,9 @@ ALTER FOREIGN DATA WRAPPER dbi LIBRARY '/home/bob/mylibrary.so';
 
   <para>
    <command>ALTER FOREIGN DATA WRAPPER</command> conforms to ISO/IEC
-   9075-9 (SQL/MED).  The standard does not specify the <literal>OWNER
-   TO</> variant of the command.
+   9075-9 (SQL/MED).  The standard does not specify the <literal>
+   VALIDATOR</literal> and <literal>OWNER TO</> variants of the
+   command.
   </para>
  </refsect1>
 

doc/src/sgml/ref/create_foreign_data_wrapper.sgml

@@ -1,5 +1,5 @@
 <!--
-$PostgreSQL: pgsql/doc/src/sgml/ref/create_foreign_data_wrapper.sgml,v 1.1 2008/12/19 16:25:16 petere Exp $
+$PostgreSQL: pgsql/doc/src/sgml/ref/create_foreign_data_wrapper.sgml,v 1.2 2009/02/24 10:06:32 petere Exp $
 PostgreSQL documentation
 -->
 
@@ -21,8 +21,7 @@ PostgreSQL documentation
  <refsynopsisdiv>
 <synopsis>
 CREATE FOREIGN DATA WRAPPER <replaceable class="parameter">name</replaceable>
-    LIBRARY '<replaceable class="parameter">libraryname</replaceable>'
-    LANGUAGE C
+    [ VALIDATOR <replaceable class="parameter">valfunction</replaceable> | NO VALIDATOR ]
     [ OPTIONS ( <replaceable class="PARAMETER">option</replaceable> '<replaceable class="PARAMETER">value</replaceable>' [, ... ] ) ]
 </synopsis>
  </refsynopsisdiv>
@@ -59,25 +58,25 @@ CREATE FOREIGN DATA WRAPPER <replaceable class="parameter">name</replaceable>
    </varlistentry>
 
    <varlistentry>
-    <term><replaceable class="parameter">libraryname</replaceable></term>
+    <term><literal>VALIDATOR <replaceable class="parameter">valfunction</replaceable></literal></term>
     <listitem>
      <para>
-      The name of the shared library implementing the foreign-data
-      wrapper.  The file name is specified in the same way as for
-      shared library names in <xref linkend="sql-createfunction"
-      endterm="sql-createfunction-title">; in particular, one can rely
-      on a search path and automatic addition of the system's standard
-      shared library file name extension.
-     </para>
-    </listitem>
-   </varlistentry>
-
-   <varlistentry>
-    <term><literal>LANGUAGE C</literal></term>
-    <listitem>
-     <para>
-      Currently, only the C programming language is supported for
-      implementing foreign-data wrappers.
+      <replaceable class="parameter">valfunction</replaceable> is the
+      name of a previously registered function that will be called to
+      check the generic options given to the foreign-data wrapper, as
+      well as to foreign servers and user mappings using the
+      foreign-data wrapper.  If no validator function or <literal>NO
+      VALIDATOR</literal> is specified, then options will not be
+      checked at creation time.  (Foreign-data wrappers will possibly
+      ignore or reject invalid option specifications at run time,
+      depending on the implementation.)  The validator function must
+      take two arguments: one of type <type>text[]</type>, which will
+      contain the array of options as stored in the system catalogs,
+      and one of type <type>oid</type>, which will be the OID of the
+      system catalog containing the options, or zero if the context is
+      not known.  The return type is ignored; the function should
+      indicate invalid options using
+      the <function>ereport()</function> function.
      </para>
     </listitem>
    </varlistentry>
@@ -109,47 +108,37 @@ CREATE FOREIGN DATA WRAPPER <replaceable class="parameter">name</replaceable>
   </para>
 
   <para>
-   The C language API for foreign-data wrappers is currently not
-   documented, stable, or complete.  Would-be authors of functionality
-   interfacing with the SQL/MED functionality are advised to contact
-   the PostgreSQL developers.
-  </para>
-
-  <para>
-   There are currently two foreign-data wrapper libraries
-   provided: <filename>dummy_fdw</filename>, which does nothing and
-   could be useful for testing,
-   and <filename>postgresql_fdw</filename>, which accepts options
-   corresponding to <application>libpq</> connection parameters.
+   There is currently one foreign-data wrapper validator function
+   provided:
+   <filename>postgresql_fdw_validator</filename>, which accepts
+   options corresponding to <application>libpq</> connection
+   parameters.
   </para>
  </refsect1>
 
  <refsect1>
   <title>Examples</title>
 
   <para>
-   Create a foreign-data wrapper <literal>dummy</> with
-   library <literal>dummy_fdw</>:
+   Create a foreign-data wrapper <literal>dummy</>:
 <programlisting>
-CREATE FOREIGN DATA WRAPPER dummy LIBRARY 'dummy_fdw' LANGUAGE C;
+CREATE FOREIGN DATA WRAPPER dummy;
 </programlisting>
   </para>
 
   <para>
    Create a foreign-data wrapper <literal>postgresql</> with
-   library <literal>postgresql_fdw</>:
+   validator function <literal>postgresql_fdw_validator</>:
 <programlisting>
-CREATE FOREIGN DATA WRAPPER postgresql LIBRARY 'postgresql_fdw' LANGUAGE C;
+CREATE FOREIGN DATA WRAPPER postgresql VALIDATOR postgresql_fdw_validator;
 </programlisting>
   </para>
 
   <para>
-   Create a foreign-data wrapper <literal>mywrapper</> with library
-   <literal>/home/bob/mywrapper.so</> and some options:
+   Create a foreign-data wrapper <literal>mywrapper</> with some
+   options:
 <programlisting>
 CREATE FOREIGN DATA WRAPPER mywrapper
-    LIBRARY '/home/bob/mywrapper.so'
-    LANGUAGE C
     OPTIONS (debug 'true');
 </programlisting>
   </para>
@@ -161,8 +150,9 @@ CREATE FOREIGN DATA WRAPPER mywrapper
   <para>
    <command>CREATE FOREIGN DATA WRAPPER</command> conforms to ISO/IEC
    9075-9 (SQL/MED), with the exception that
-   the <literal>LIBRARY</literal> clause is not optional in
-   PostgreSQL.
+   the <literal>VALIDATOR</literal> clause is an extension and the
+   clauses <literal>LIBRARY</literal> and <literal>LANGUAGE</literal>
+   are not yet implemented in PostgreSQL.
   </para>
 
   <para>

src/Makefile

@@ -4,7 +4,7 @@
 #
 # Copyright (c) 1994, Regents of the University of California
 #
-# $PostgreSQL: pgsql/src/Makefile,v 1.44 2008/12/19 16:25:16 petere Exp $
+# $PostgreSQL: pgsql/src/Makefile,v 1.45 2009/02/24 10:06:32 petere Exp $
 #
 #-------------------------------------------------------------------------
 
@@ -19,7 +19,6 @@ all install installdirs uninstall distprep:
 	$(MAKE) -C backend $@
 	$(MAKE) -C backend/utils/mb/conversion_procs $@
 	$(MAKE) -C backend/snowball $@
-	$(MAKE) -C backend/foreign $@-fdw
 	$(MAKE) -C include $@
 	$(MAKE) -C interfaces $@
 	$(MAKE) -C bin $@

src/backend/catalog/information_schema.sql

@@ -4,7 +4,7 @@
  *
  * Copyright (c) 2003-2009, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/backend/catalog/information_schema.sql,v 1.52 2009/02/14 20:48:36 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/catalog/information_schema.sql,v 1.53 2009/02/24 10:06:32 petere Exp $
  */
 
 /*
@@ -2428,7 +2428,6 @@ CREATE VIEW _pg_foreign_data_wrappers AS
            CAST(current_database() AS sql_identifier) AS foreign_data_wrapper_catalog,
            CAST(fdwname AS sql_identifier) AS foreign_data_wrapper_name,
            CAST(u.rolname AS sql_identifier) AS authorization_identifier,
-           CAST(fdwlibrary AS character_data) AS library_name,
            CAST('c' AS character_data) AS foreign_data_wrapper_language
     FROM pg_foreign_data_wrapper w, pg_authid u
     WHERE u.oid = w.fdwowner
@@ -2458,7 +2457,7 @@ CREATE VIEW foreign_data_wrappers AS
     SELECT foreign_data_wrapper_catalog,
            foreign_data_wrapper_name,
            authorization_identifier,
-           library_name,
+           CAST(NULL AS character_data) AS library_name,
            foreign_data_wrapper_language
     FROM _pg_foreign_data_wrappers w;