Fix typo that had the code check the same thing twice.

mhagander · mhagander · commit 81fb51732e97 · 2010-04-28T13:46:23.000Z
Fujii Masao
diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.42 2010/01/15 09:19:10 heikki Exp $
+ *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.43 2010/04/28 13:46:23 mha Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1909,7 +1909,7 @@ build_startup_packet(const PGconn *conn, char *packet,
 		ADD_STARTUP_OPTION("user", conn->pguser);
 	if (conn->dbName && conn->dbName[0])
 		ADD_STARTUP_OPTION("database", conn->dbName);
-	if (conn->replication && conn->replication)
+	if (conn->replication && conn->replication[0])
 		ADD_STARTUP_OPTION("replication", conn->replication);
 	if (conn->pgoptions && conn->pgoptions[0])
 		ADD_STARTUP_OPTION("options", conn->pgoptions);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.42 2010/01/15 09:19:10 heikki Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.43 2010/04/28 13:46:23 mha Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1909,7 +1909,7 @@ build_startup_packet(const PGconn conn, char packet,`
`1909`	`1909`	`ADD_STARTUP_OPTION("user", conn->pguser);`
`1910`	`1910`	`if (conn->dbName && conn->dbName[0])`
`1911`	`1911`	`ADD_STARTUP_OPTION("database", conn->dbName);`
`1912`		`- if (conn->replication && conn->replication)`
	`1912`	`+ if (conn->replication && conn->replication[0])`
`1913`	`1913`	`ADD_STARTUP_OPTION("replication", conn->replication);`
`1914`	`1914`	`if (conn->pgoptions && conn->pgoptions[0])`
`1915`	`1915`	`ADD_STARTUP_OPTION("options", conn->pgoptions);`